Skip to content

fix(test): handle non-ASCII project paths in ShellCommandToolTest #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
YunKuiLu wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −2
Open

fix(test): handle non-ASCII project paths in ShellCommandToolTest #1411

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions agentscope-core/src/test/java/io/agentscope/core/tool/coding/ShellCommandToolTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -873,10 +873,17 @@ void reproduceLargeFileCatDeadlock() throws Exception {
@Test
@DisplayName("Should handle pre-created large test file without deadlock")
@EnabledOnOs({OS.LINUX, OS.MAC})
void reproduceLargeFileCatDeadlockWithTestResource() {
void reproduceLargeFileCatDeadlockWithTestResource() throws Exception {
// Use the pre-created test resource file (20KB)
// Use Paths.get(url.toURI()) instead of url.getPath() to properly decode
// URL-encoded characters (e.g. Chinese characters in project path)
String resourcePath =
getClass().getClassLoader().getResource("large_output_test.txt").getPath();
Paths.get(
getClass()
.getClassLoader()
.getResource("large_output_test.txt")
.toURI())
.toString();
String command = "cat " + resourcePath;

// Set a reasonable timeout - should complete quickly with the fix
Expand Down
Loading