fix(test): handle non-ASCII project paths in ShellCommandToolTest#1411
Open
YunKuiLu wants to merge 1 commit into
Open
fix(test): handle non-ASCII project paths in ShellCommandToolTest#1411YunKuiLu wants to merge 1 commit into
YunKuiLu wants to merge 1 commit into
Conversation
URL.getPath() returns URL-encoded path which breaks shell command execution when project directory contains non-ASCII characters (e.g. Chinese). Use Paths.get(url.toURI()).toString() instead to properly decode the resource path.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reproduceLargeFileCatDeadlockWithTestResourcetest failure when the project directory contains non-ASCII characters (e.g. Chinese characters like工程)Root Cause
URL.getPath()returns URL-encoded paths (e.g.%E5%AD%A6%E4%B9%A0). When this encoded path is passed tosh -c "cat ...", the shell treats the percent-encoded characters as literal characters and cannot find the file, causing the test to fail with a non-zero return code.Fix
Replace
getClass().getClassLoader().getResource("large_output_test.txt").getPath()withPaths.get(getClass().getClassLoader().getResource("large_output_test.txt").toURI()).toString()to properly decode the URI into a valid filesystem path.Test Plan
mvn test -f agentscope-core/pom.xml -Dtest="ShellCommandToolTest\$BufferDeadlockTests#reproduceLargeFileCatDeadlockWithTestResource"passes