Skip to content

fix: handle CSS-escaped form IDs in form vitals extraction #1272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anshikag-adobe merged 2 commits into from
Feb 5, 2026
Merged

fix: handle CSS-escaped form IDs in form vitals extraction #1272

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f338fd0
fix: handle CSS-escaped form IDs in form vitals extraction
anshikag-adobe Jan 21, 2026
36a7f21
fix: update formSource match regex
anshikag-adobe Jan 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/spacecat-shared-rum-api-client/src/functions/form-vitals.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,8 @@ function handler(bundles) {

globalFormSourceSet.forEach((source) => {
// counts metrics per each group
const match = source.match(/form[#.](\w+)/);
// Match form ID/class including CSS escape sequences (e.g., form#\35 57238494 or form#abc)
const match = source.match(/form[#.]((?:\\[0-9a-fA-F]{1,6}\s?|\w|-)+)/);
const formsource = match ? match[1] : 'unknown';
// groups by url and user agent
dataChunks.addFacet('urlUserAgents', (bundle) => {
Expand Down