fix: handle CSS-escaped form IDs in form vitals extraction #1272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| // counts metrics per each group | ||
| const match = source.match(/form[#.](\w+)/); | ||
| // Unescape CSS escape sequences (e.g., \35 -> 5) | ||
| const unescapedSource = source.replace(/\\([0-9a-fA-F]{1,6})\s?/g, (_, hex) => String.fromCharCode(parseInt(hex, 16))); |
Contributor
There was a problem hiding this comment.
can you share an example please, where did you encounter this.
Contributor
There was a problem hiding this comment.
can you confirm if the document.querySelector works after this change ?
Author
There was a problem hiding this comment.
@05rahulsingh
Example:
form has id 5464aa16
form source in rum data: #container-a89bac44d9 form#\\35 464aa16
hence the regex here doesn't match and the formSource is not sent ahead.
Author
There was a problem hiding this comment.
@vdua I checked querySelector doesn't work after this change, fixing it in few.
Author
There was a problem hiding this comment.
@vdua I have changed the regex only to match both sourceIDs with or without hexadecimal number
|
This PR will trigger a patch release when merged. |
anshikag-adobe
force-pushed
the
fix/formsource
branch
from
d1ba9f7 to
36a7f21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please ensure your pull request adheres to the following guidelines:
Related Issues
Thanks for contributing!
JIRA: https://jira.corp.adobe.com/browse/FORMS-23719