Skip to content

Conversation

@shazron
Copy link
Member

@shazron shazron commented May 22, 2025

Description

This PR adds App Builder Deploy Service support for some commands. The Deploy Service requires a user access token (by user login) or a technical account token. The commands are:

  • aio rt action create/update/delete/update
  • aio api create/delete
  • aio rt deploy sync/undeploy
  • aio rt rule create/delete/update/disable/enable
  • aio rt trigger create/delete/update

You can use Runtime credential basic auth by the --use-runtime-auth flag for any of these commands, or set the environment variable USE_RUNTIME_AUTH=1 to enable it globally.

Some users use the Runtime plugin as a substitute for the wsk cli (since it's a near 1:1 drop-in replacement), so the flag and env var is there to support that scenario.

How Has This Been Tested?

  • npm test
  • called all the commands above via the command line with a user login
  • tested aio rt trigger with both the --use-runtime-auth flag, and the global env var USE_RUNTIME_AUTH
  • sampled other aio rt commands to make sure they don't use the Deploy Service

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented May 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (abaf187) to head (7c9060c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #385   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           66        67    +1     
  Lines         1758      1792   +34     
  Branches       371       379    +8     
=========================================
+ Hits          1758      1792   +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shazron shazron changed the title feat: ACNA-3833 - add Deploy Service support for some commands feat(breaking-change): ACNA-3833 - add Deploy Service support for some commands May 22, 2025
@shazron shazron changed the title feat(breaking-change): ACNA-3833 - add Deploy Service support for some commands breaking-change: ACNA-3833 - add Deploy Service support for some commands May 22, 2025
@shazron shazron merged commit 6e98764 into master May 23, 2025
10 checks passed
@shazron shazron deleted the story/ACNA-3833 branch May 23, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants