Skip to content

Conversation

@shazron
Copy link
Member

@shazron shazron commented May 22, 2025

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@shazron
Copy link
Member Author

shazron commented May 23, 2025

Confirmed on Windows 11, the error is there. There is no error on macOS:

 PASS  test/LogForwardingUnderscoreNamespace.test.js
 PASS  test/LogForwarding.test.js
 PASS  test/print.action.logs.test.js (5.03 s)
 PASS  test/undeploy.actions.test.js (5.049 s)
 PASS  test/index.test.js (5.213 s)
 PASS  test/deploy.actions.test.js (5.258 s)
 FAIL  test/utils.test.js (5.568 s)
  ● zip › should fail if file does not exists

    expect(received).toEqual(expected) // deep equality

    Expected: false
    Received: true

      2235 |     expect(archiver.mockFile).toHaveBeenCalledTimes(0)
      2236 |     expect(archiver.mockDirectory).toHaveBeenCalledTimes(0)
    > 2237 |     expect(fs.existsSync('/out.zip')).toEqual(false)
           |                                       ^
      2238 |   })
      2239 |
      2240 |   test('should fail if there is a stream error', async () => {

      at Object.toEqual (test/utils.test.js:2237:39)

 PASS  test/build.actions.test.js (5.723 s)
-------------------------------------------|---------|----------|---------|---------|-------------------
File                                       | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s
-------------------------------------------|---------|----------|---------|---------|-------------------
All files                                  |     100 |      100 |     100 |     100 |
 LogForwarding.js                          |     100 |      100 |     100 |     100 |
 LogForwardingLocalDestinationsProvider.js |     100 |      100 |     100 |     100 |
 RuntimeAPI.js                             |     100 |      100 |     100 |     100 |
 SDKErrors.js                              |     100 |      100 |     100 |     100 |
 build-actions.js                          |     100 |      100 |     100 |     100 |
 deploy-actions.js                         |     100 |      100 |     100 |     100 |
 index.js                                  |     100 |      100 |     100 |     100 |
 print-action-logs.js                      |     100 |      100 |     100 |     100 |
 triggers.js                               |     100 |      100 |     100 |     100 |
 undeploy-actions.js                       |     100 |      100 |     100 |     100 |
 utils.js                                  |     100 |      100 |     100 |     100 |
-------------------------------------------|---------|----------|---------|---------|-------------------

Test Suites: 1 failed, 7 passed, 8 total
Tests:       1 failed, 350 passed, 351 total
Snapshots:   0 total
Time:        7.126 s
Ran all test suites.

@codecov
Copy link

codecov bot commented May 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f66283f) to head (66a58ed).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #214   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         1354      1347    -7     
  Branches       350       347    -3     
=========================================
- Hits          1354      1347    -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shazron shazron merged commit a9e7025 into master May 23, 2025
10 checks passed
@shazron shazron deleted the story/ACNA-3696 branch May 23, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants