Skip to content

Use flex for radio layout #11254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
joedolson wants to merge 1 commit into
base: trunk
Choose a base branch
from
+2 −12
Open

Use flex for radio layout #11254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 2 additions & 12 deletions src/wp-admin/css/forms.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,10 +171,9 @@ td > input[type="checkbox"],
}

input[type="radio"] {
display: inline-flex;
border-radius: 50%;
margin-right: 0.25rem;
/* 10px not sure if still necessary, comes from the MP6 redesign in r26072 */
line-height: 0.71428571;
}
Copy link

@sabernhardt sabernhardt Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alignment can still be slightly off at various window widths and zoom levels. Adding this seems to help:

Suggested change
}
align-items: center;
justify-content: center;
}


input[type="checkbox"]:checked::before,
Expand Down Expand Up @@ -211,10 +210,8 @@ input[type="radio"]:checked::before {
border-radius: 50%;
width: 0.5rem; /* 8px */
height: 0.5rem; /* 8px */
margin: 0.1875rem; /* 3px */
margin: auto;
background-color: #fff;
/* 16px not sure if still necessary, comes from the MP6 redesign in r26072 */
line-height: 1.14285714;
}
Copy link

@sabernhardt sabernhardt Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to alignment, Windows High Contrast mode does not indicate checked radio buttons (for a long time). I was going to open a separate ticket, but this is already editing the same ruleset.

Suggested change
}
/* Only visible in Windows High Contrast mode */
outline: 4px solid transparent;
}

Screenshots using Chrome 145 and Windows 11's Aquatic theme:

Before With outline
radio buttons without outline checked radio buttons with outline


@-moz-document url-prefix() {
Expand Down Expand Up @@ -957,13 +954,6 @@ ul#add-to-blog-users {
line-height: 1.4;
}

.form-table input.tog,
.form-table input[type="radio"] {
margin-top: -4px;
margin-right: 4px;
float: none;
}

.form-table .pre {
padding: 8px;
margin: 0;
Expand Down
Loading