Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
Should That class is extremely ancient and it doesn't currently seem to serve any purpose (if it ever did). |
|
I checked CSS, but i didn't check whether it was used in JS anywhere. It might be possible to remove; that will need a bit more checking. It's definitely very old! |
| margin-right: 0.25rem; | ||
| /* 10px not sure if still necessary, comes from the MP6 redesign in r26072 */ | ||
| line-height: 0.71428571; | ||
| } |
There was a problem hiding this comment.
The alignment can still be slightly off at various window widths and zoom levels. Adding this seems to help:
| } | |
| align-items: center; | |
| justify-content: center; | |
| } |
| background-color: #fff; | ||
| /* 16px not sure if still necessary, comes from the MP6 redesign in r26072 */ | ||
| line-height: 1.14285714; | ||
| } |
There was a problem hiding this comment.
Unrelated to alignment, Windows High Contrast mode does not indicate checked radio buttons (for a long time). I was going to open a separate ticket, but this is already editing the same ruleset.
| } | |
| /* Only visible in Windows High Contrast mode */ | |
| outline: 4px solid transparent; | |
| } |
Screenshots using Chrome 145 and Windows 11's Aquatic theme:
| Before | With outline |
|---|---|
 |
 |
3 participants
This PR extends the patch by @siliconforks to remove some additional CSS.
The class
.togis used only on the adim theme color switching and in the selector to set the front page between a page or a post. Removing these styles appears to have no impact. The line-height also appears to now be irrelevant.Some additional cross-browser testing would probably be beneficial.
Trac ticket: https://core.trac.wordpress.org/ticket/64816
Use of AI Tools
None
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.