fix: filter clinical control options to current mapped variants only#701
Open
bencap wants to merge 1 commit intorelease-2026.1.3from
Open
Conversation
The /score-sets/{urn}/clinical-controls/options endpoint was returning
options derived from all mapped variants, including stale (non-current)
ones. The sibling /clinical-controls endpoint already applied
MappedVariant.current.is_(True); this endpoint simply missed it.
Adds a regression test that marks all mapped variants as non-current
and asserts the options endpoint returns 404, directly proving the
filter is enforced.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The /score-sets/{urn}/clinical-controls/options endpoint was returning options derived from all mapped variants, including stale (non-current) ones. The sibling /clinical-controls endpoint already applied MappedVariant.current.is_(True); this endpoint simply missed it.
Adds a regression test that marks all mapped variants as non-current and asserts the options endpoint returns 404, directly proving the filter is enforced.