Use keyword args for from_response_dict calls#2884
Merged
adamtheturtle merged 1 commit intomainfrom Feb 25, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace positional calls to from_response_dict with explicit response_dict= keyword arguments in sync and async VWS/query codepaths. This removes the # type: ignore[misc] overrides while preserving behavior.
Note
Low Risk
Low risk refactor that only changes call syntax for response parsing helpers; runtime behavior should remain identical aside from surfacing any previously-hidden signature mismatches.
Overview
Updates sync/async CloudReco and VWS codepaths to call
from_response_dictusing the explicitresponse_dict=keyword (including list comprehensions for query results and report constructors).This removes the prior
# type: ignore[misc]suppressions and makes response-parsing call sites consistent without changing the underlying request/response behavior.Written by Cursor Bugbot for commit 323c8e5. This will update automatically on new commits. Configure here.