Skip to content

Use keyword args for from_response_dict calls#2884

Merged
adamtheturtle merged 1 commit intomainfrom
adamtheturtle/use-kwargs
Feb 25, 2026
Merged

Use keyword args for from_response_dict calls#2884
adamtheturtle merged 1 commit intomainfrom
adamtheturtle/use-kwargs

Conversation

@adamtheturtle
Copy link
Member

@adamtheturtle adamtheturtle commented Feb 25, 2026

Replace positional calls to from_response_dict with explicit response_dict= keyword arguments in sync and async VWS/query codepaths. This removes the # type: ignore[misc] overrides while preserving behavior.


Note

Low Risk
Low risk refactor that only changes call syntax for response parsing helpers; runtime behavior should remain identical aside from surfacing any previously-hidden signature mismatches.

Overview
Updates sync/async CloudReco and VWS codepaths to call from_response_dict using the explicit response_dict= keyword (including list comprehensions for query results and report constructors).

This removes the prior # type: ignore[misc] suppressions and makes response-parsing call sites consistent without changing the underlying request/response behavior.

Written by Cursor Bugbot for commit 323c8e5. This will update automatically on new commits. Configure here.

@adamtheturtle adamtheturtle merged commit 66d4873 into main Feb 25, 2026
14 checks passed
@adamtheturtle adamtheturtle deleted the adamtheturtle/use-kwargs branch February 25, 2026 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant