Skip to content

Commit 66d4873

Browse files
Merge pull request #2884 from VWS-Python/adamtheturtle/use-kwargs
Use keyword args for from_response_dict calls
2 parents f3b356f + 323c8e5 commit 66d4873

File tree

4 files changed

+26
-8
lines changed

4 files changed

+26
-8
lines changed

src/vws/async_query.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,4 +199,7 @@ async def query(
199199
result_list = list(
200200
json.loads(s=response.text)["results"],
201201
)
202-
return [QueryResult.from_response_dict(item) for item in result_list] # type: ignore[misc]
202+
return [
203+
QueryResult.from_response_dict(response_dict=item)
204+
for item in result_list
205+
]

src/vws/async_vws.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -296,7 +296,9 @@ async def get_target_record(self, target_id: str) -> TargetStatusAndRecord:
296296
)
297297

298298
result_data = json.loads(s=response.text)
299-
return TargetStatusAndRecord.from_response_dict(result_data) # type: ignore[misc]
299+
return TargetStatusAndRecord.from_response_dict(
300+
response_dict=result_data,
301+
)
300302

301303
async def wait_for_target_processed(
302304
self,
@@ -431,7 +433,9 @@ async def get_target_summary_report(
431433
)
432434

433435
result_data = dict(json.loads(s=response.text))
434-
return TargetSummaryReport.from_response_dict(result_data) # type: ignore[misc]
436+
return TargetSummaryReport.from_response_dict(
437+
response_dict=result_data,
438+
)
435439

436440
async def get_database_summary_report(
437441
self,
@@ -466,7 +470,9 @@ async def get_database_summary_report(
466470
)
467471

468472
response_data = dict(json.loads(s=response.text))
469-
return DatabaseSummaryReport.from_response_dict(response_data) # type: ignore[misc]
473+
return DatabaseSummaryReport.from_response_dict(
474+
response_dict=response_data,
475+
)
470476

471477
async def delete_target(self, target_id: str) -> None:
472478
"""Delete a given target.

src/vws/query.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -165,4 +165,7 @@ def query(
165165
raise exception(response=response)
166166

167167
result_list = list(json.loads(s=response.text)["results"])
168-
return [QueryResult.from_response_dict(item) for item in result_list] # type: ignore[misc]
168+
return [
169+
QueryResult.from_response_dict(response_dict=item)
170+
for item in result_list
171+
]

src/vws/vws.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,9 @@ def get_target_record(self, target_id: str) -> TargetStatusAndRecord:
281281
)
282282

283283
result_data = json.loads(s=response.text)
284-
return TargetStatusAndRecord.from_response_dict(result_data) # type: ignore[misc]
284+
return TargetStatusAndRecord.from_response_dict(
285+
response_dict=result_data,
286+
)
285287

286288
def wait_for_target_processed(
287289
self,
@@ -405,7 +407,9 @@ def get_target_summary_report(self, target_id: str) -> TargetSummaryReport:
405407
)
406408

407409
result_data = dict(json.loads(s=response.text))
408-
return TargetSummaryReport.from_response_dict(result_data) # type: ignore[misc]
410+
return TargetSummaryReport.from_response_dict(
411+
response_dict=result_data,
412+
)
409413

410414
def get_database_summary_report(self) -> DatabaseSummaryReport:
411415
"""Get a summary report for the database.
@@ -438,7 +442,9 @@ def get_database_summary_report(self) -> DatabaseSummaryReport:
438442
)
439443

440444
response_data = dict(json.loads(s=response.text))
441-
return DatabaseSummaryReport.from_response_dict(response_data) # type: ignore[misc]
445+
return DatabaseSummaryReport.from_response_dict(
446+
response_dict=response_data,
447+
)
442448

443449
def delete_target(self, target_id: str) -> None:
444450
"""Delete a given target.

0 commit comments

Comments
 (0)