Skip to content

Switch from pre-commit to prek #2774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adamtheturtle merged 7 commits into from
Jan 2, 2026
Merged

Switch from pre-commit to prek #2774

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ed0c648
Switch from pre-commit to prek
adamtheturtle Jan 2, 2026
8521279
Undo some unnecessary changes
adamtheturtle Jan 2, 2026
e2c817a
Remove stage
adamtheturtle Jan 2, 2026
1a622a6
Remove changes
adamtheturtle Jan 2, 2026
dee2727
Test a change
adamtheturtle Jan 2, 2026
bcb26d1
Undo a change
adamtheturtle Jan 2, 2026
833c51f
[pre-commit.ci lite] apply automatic fixes
pre-commit-ci-lite[bot] Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/lint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,9 @@ jobs:

- name: Lint
run: |
uv run --extra=dev pre-commit run --all-files --hook-stage pre-commit --verbose
uv run --extra=dev pre-commit run --all-files --hook-stage pre-push --verbose
uv run --extra=dev pre-commit run --all-files --hook-stage manual --verbose
uv run --extra=dev prek run --all-files --hook-stage pre-commit --verbose
uv run --extra=dev prek run --all-files --hook-stage pre-push --verbose
uv run --extra=dev prek run --all-files --hook-stage manual --verbose
Copy link
Copy Markdown

@cursor cursor Bot Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pre-commit-ci/lite-action step not removed as intended

The PR description states "Remove pre-commit-ci/lite-action step" but this step is still present in the workflow. The pre-commit-ci/lite-action is specifically designed to work with pre-commit to auto-fix PRs, not with prek. Since the PR switches to prek, this action won't function as intended and represents either dead code or broken functionality for auto-fixing PRs.

Fix in Cursor Fix in Web

env:
UV_PYTHON: ${{ matrix.python-version }}

Expand All @@ -47,7 +47,7 @@ jobs:
completion-lint:
needs: build
runs-on: ubuntu-latest
if: always() # Run even if one matrix job fails
if: always() # Run even if one matrix job fails
steps:
- name: Check matrix job status
run: |-
Expand Down
59 changes: 9 additions & 50 deletions .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,58 +1,14 @@
---
fail_fast: true

# See https://pre-commit.com for more information
# See https://pre-commit.com/hooks.html for more hooks

ci:
# We use system Python, with required dependencies specified in pyproject.toml.
# We therefore cannot use those dependencies in pre-commit CI.
skip:
- actionlint
- sphinx-lint
- check-manifest
- deptry
- doc8
- docformatter
- docs
- interrogate
- interrogate-docs
- linkcheck
- mypy
- mypy-docs
- pylint
- pyproject-fmt-fix
- pyright
- pyright-docs
- pyright-verifytypes
- ty
- ty-docs
- pyroma
- ruff-check-fix
- ruff-check-fix-docs
- ruff-format-fix
- ruff-format-fix-docs
- shellcheck
- shellcheck-docs
- shfmt
- shfmt-docs
- spelling
- vulture
- vulture-docs
- yamlfix
- zizmor
- pyrefly
- pyrefly-docs
# See https://prek.j178.dev for more information



default_install_hook_types: [pre-commit, pre-push, commit-msg]

repos:
- repo: meta
hooks:
- id: check-useless-excludes
stages: [pre-commit]
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v6.0.0
- repo: builtin
hooks:
- id: check-added-large-files
stages: [pre-commit]
Expand All @@ -76,11 +32,14 @@ repos:
stages: [pre-commit]
- id: end-of-file-fixer
stages: [pre-commit]
- id: trailing-whitespace
stages: [pre-commit]
- repo: https://github.com/pre-commit/pre-commit-hooks
rev: v6.0.0
hooks:
- id: file-contents-sorter
files: spelling_private_dict\.txt$
stages: [pre-commit]
- id: trailing-whitespace
stages: [pre-commit]
- repo: https://github.com/pre-commit/pygrep-hooks
rev: v1.10.0
hooks:
Expand Down
10 changes: 5 additions & 5 deletions docs/source/contributing.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,11 +27,11 @@ and on Ubuntu with ``apt``:

$ apt-get install -y enchant

Install ``pre-commit`` hooks:
Install ``prek`` hooks:

.. code-block:: console

$ pre-commit install
$ prek install

Linting
-------
Expand All @@ -40,9 +40,9 @@ Run lint tools either by committing, or with:

.. code-block:: console

$ pre-commit run --all-files --hook-stage pre-commit --verbose
$ pre-commit run --all-files --hook-stage pre-push --verbose
$ pre-commit run --all-files --hook-stage manual --verbose
$ prek run --all-files --hook-stage pre-commit --verbose
$ prek run --all-files --hook-stage pre-push --verbose
$ prek run --all-files --hook-stage manual --verbose

.. _Homebrew: https://brew.sh

Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ optional-dependencies.dev = [
"interrogate==1.7.0",
"mypy[faster-cache]==1.19.1",
"mypy-strict-kwargs==2025.4.3",
"pre-commit==4.5.1",
"prek==0.2.25",
"pydocstyle==6.3",
"pygments==2.19.2",
"pylint[spelling]==4.0.4",
Expand Down
Loading