Merged
Conversation
- Replace pre-commit with prek in pyproject.toml dev dependencies - Update .pre-commit-config.yaml to use prek builtin hooks - Remove pre-commit CI configuration (ci: section) - Update GitHub Actions workflow to use prek commands - Update contributing documentation for prek
| uv run --extra=dev pre-commit run --all-files --hook-stage manual --verbose | ||
| uv run --extra=dev prek run --all-files --hook-stage pre-commit --verbose | ||
| uv run --extra=dev prek run --all-files --hook-stage pre-push --verbose | ||
| uv run --extra=dev prek run --all-files --hook-stage manual --verbose |
There was a problem hiding this comment.
pre-commit-ci/lite-action step not removed as intended
The PR description states "Remove pre-commit-ci/lite-action step" but this step is still present in the workflow. The pre-commit-ci/lite-action is specifically designed to work with pre-commit to auto-fix PRs, not with prek. Since the PR switches to prek, this action won't function as intended and represents either dead code or broken functionality for auto-fixing PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR migrates from
pre-committoprek, a faster Rust-based alternative.Changes
pre-commitwithprekin pyproject.toml dev dependenciesci:section)prekcommandsWhy prek?
See https://prek.j178.dev for more information.
Note
Migrates repository linting workflow and tooling from
pre-committoprek.pre-commitdev dependency withprekinpyproject.tomllint.ymlto runuv run ... prek runforpre-commit,pre-push, andmanualstagesdocs/source/contributing.rst) to install and runprekinstead ofpre-commit.pre-commit-config.yamlto setdefault_install_hook_typesto[pre-commit, pre-push]Written by Cursor Bugbot for commit bcb26d1. This will update automatically on new commits. Configure here.