Use vws-python 2026.2.25.1 and simplify respx tests#3019
Merged
adamtheturtle merged 2 commits intomainfrom Feb 25, 2026
Merged
Conversation
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| ) | ||
| await vws_client.wait_for_target_processed(target_id=target_id) | ||
| results = await query_client.query(image=high_quality_image) | ||
| assert [result.target_id for result in results] == [target_id] |
There was a problem hiding this comment.
BytesIO reused for add and query without seek
Medium Severity
The same high_quality_image BytesIO is passed to add_target and then query. Uploading for add_target advances the stream position to EOF, so query reads from EOF and sends empty image data. The query therefore returns no matches and the assertion fails.
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the dev dependency pin to vws-python 2026.2.25.1. Replace the large raw-httpx respx usage test mirror with a smaller async vws-python client suite covering AsyncVWS, AsyncCloudRecoService, and AsyncVuMarkService through MockVWS. This keeps httpx/respx interception coverage while reducing duplication and boilerplate in the test suite.
Note
Low Risk
Low risk: dependency pin bump plus a test-only refactor; main risk is reduced coverage for raw
httpx/non-Vuforia passthrough behavior compared to the previous suite.Overview
Updates the dev dependency pin for
vws-pythonto2026.2.25.1.Refactors
test_respx_mock_usage.pyby replacing the large raw-httpxinterception suite with a smaller set of async integration tests that exerciseMockVWSviavwsasync clients (AsyncVWS,AsyncCloudRecoService,AsyncVuMarkService), covering timeout propagation, custom base URL path prefixes, target lifecycle operations, cloud query matching (usingExactMatcher), and VuMark PNG byte responses.Written by Cursor Bugbot for commit e2019ab. This will update automatically on new commits. Configure here.