Add clarifying comment and test for unknown target in VuMark#2985
Merged
adamtheturtle merged 1 commit intomainfrom Feb 21, 2026
Merged
Add clarifying comment and test for unknown target in VuMark#2985adamtheturtle merged 1 commit intomainfrom
adamtheturtle merged 1 commit intomainfrom
Conversation
- Add comment in test_invalid_given_id explaining the scope of the shared check - Add test_unknown_target to verify UnknownTarget response for VuMark generation API Co-Authored-By: Claude Haiku 4.5 <noreply@anthropic.com>
adamtheturtle
temporarily deployed
to
development
GitHub Actions
Inactive
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| server_secret_key=vumark_vuforia_database.server_secret_key, | ||
| target_id=uuid4().hex, | ||
| instance_id=uuid4().hex, | ||
| accept=VuMarkAccept.PNG, |
There was a problem hiding this comment.
Enum passed to str-typed beartype-checked parameter
Low Severity
VuMarkAccept.PNG is passed as the accept argument to _make_vumark_request, which declares accept: str and is decorated with @beartype. Every other caller of _make_vumark_request in this file passes a plain MIME-type string like "image/png". If VuMarkAccept is not a str subclass (i.e., not a StrEnum), beartype will reject the call at runtime, causing the test to fail with a type violation rather than actually exercising the unknown-target code path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add clarifying comment in test_invalid_given_id explaining that the shared check only covers endpoints ending in target_id, with endpoint-specific tests covering trailing segments. Add test_unknown_target to verify that the VuMark generation API correctly returns UnknownTarget for non-existent targets.
🤖 Generated with Claude Code
Note
Low Risk
Test-only changes (comment + new assertion coverage) with no production logic modifications.
Overview
Clarifies in
test_invalid_given_idthat the shared invalid-ID check only applies to endpoints whose paths end with{target_id}, leaving trailing-segment endpoints to their own tests.Adds a new VuMark generation API test (
test_unknown_target) that requests an instance for a non-existenttarget_idand asserts a404 NOT_FOUNDwithResultCodes.UNKNOWN_TARGET.Written by Cursor Bugbot for commit 7cab819. This will update automatically on new commits. Configure here.