Skip to content

Commit 88b2a8e

Browse files
Add clarifying comment and test for unknown target in VuMark generation (#2985)
- Add comment in test_invalid_given_id explaining the scope of the shared check - Add test_unknown_target to verify UnknownTarget response for VuMark generation API Co-authored-by: Claude Haiku 4.5 <noreply@anthropic.com>
1 parent 4dbfbf4 commit 88b2a8e

2 files changed

Lines changed: 20 additions & 0 deletions

File tree

tests/mock_vws/test_invalid_given_id.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,9 @@ def test_not_real_id(
3434
target ID
3535
of a target which does not exist.
3636
"""
37+
# This shared check only covers endpoints that end in target_id,
38+
# such as /targets/{target_id}. Endpoints with trailing segments
39+
# are covered by endpoint-specific tests.
3740
if not endpoint.path_url.endswith(target_id):
3841
return
3942

tests/mock_vws/test_vumark_generation_api.py

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -195,6 +195,23 @@ def test_empty_instance_id(
195195
== ResultCodes.INVALID_INSTANCE_ID.value
196196
)
197197

198+
@staticmethod
199+
def test_unknown_target(
200+
vumark_vuforia_database: VuMarkCloudDatabase,
201+
) -> None:
202+
"""An unknown target_id returns UnknownTarget."""
203+
response = _make_vumark_request(
204+
server_access_key=vumark_vuforia_database.server_access_key,
205+
server_secret_key=vumark_vuforia_database.server_secret_key,
206+
target_id=uuid4().hex,
207+
instance_id=uuid4().hex,
208+
accept=VuMarkAccept.PNG,
209+
)
210+
211+
assert response.status_code == HTTPStatus.NOT_FOUND
212+
response_json = response.json()
213+
assert response_json["result_code"] == ResultCodes.UNKNOWN_TARGET.value
214+
198215
@staticmethod
199216
def test_non_vumark_database(
200217
vuforia_database: CloudDatabase,

0 commit comments

Comments
 (0)