Skip to content

feat(ui5-dynamic-side-content): add 'role' property to accessibilityAttributes object #13476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
NHristov-sap wants to merge 2 commits into
base: main
Choose a base branch
from
+10 −3
Draft

feat(ui5-dynamic-side-content): add 'role' property to accessibilityAttributes object #13476

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ae96f1b
feat(ui5-dynamic-side-content): add 'role' property in accessibilityA…
NHristov-sap May 5, 2026
c51227d
feat(ui5-dymnamic-side-content): add option to remove roles
NHristov-sap May 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/fiori/src/DynamicSideContent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ type DynamicSideContentLayoutChangeEventDetail = {
sideContentVisible: boolean,
}

type DynamicSideContentAriaAccessibilityAttributes = Pick<AccessibilityAttributes, "ariaLabel">;
type DynamicSideContentAriaAccessibilityAttributes = Pick<AccessibilityAttributes, "ariaLabel" | "role">;
type DynamicSideContentAccessibilityAttributes = {
mainContent?: DynamicSideContentAriaAccessibilityAttributes,
sideContent?: DynamicSideContentAriaAccessibilityAttributes,
Expand Down Expand Up @@ -370,12 +370,17 @@ class DynamicSideContent extends UI5Element {
}

get accInfo(): DynamicSideContentAccessibilityAttributes {
const hasMainRole = Object.prototype.hasOwnProperty.call(this.accessibilityAttributes.mainContent || {}, "role");
const hasSideRole = Object.prototype.hasOwnProperty.call(this.accessibilityAttributes.sideContent || {}, "role");

return {
mainContent: {
ariaLabel: this.accessibilityAttributes.mainContent?.ariaLabel || DynamicSideContent.i18nBundle.getText(DSC_MAIN_ARIA_LABEL),
role: hasMainRole ? this.accessibilityAttributes.mainContent?.role : "main",
},
sideContent: {
ariaLabel: this.accessibilityAttributes.sideContent?.ariaLabel || DynamicSideContent.i18nBundle.getText(DSC_SIDE_ARIA_LABEL),
role: hasSideRole ? this.accessibilityAttributes.sideContent?.role : "complementary",
},
};
}
Expand Down
4 changes: 2 additions & 2 deletions packages/fiori/src/DynamicSideContentTemplate.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ export default function DynamicSideContentTemplate(this: DynamicSideContent) {
function mainContent(this: DynamicSideContent) {
return (
<div
role="main"
role={this.accInfo.mainContent?.role}
aria-label={this.accInfo.mainContent?.ariaLabel}
class={this.classes.main}
style={this.styles.main}
Expand All @@ -37,7 +37,7 @@ function mainContent(this: DynamicSideContent) {
function sideContent(this: DynamicSideContent) {
return (
<aside
role="complementary"
role={this.accInfo.sideContent?.role}
aria-label={this.accInfo.sideContent?.ariaLabel}
class={this.classes.side}
style={this.styles.side}
Expand Down
2 changes: 2 additions & 0 deletions packages/fiori/test/pages/DynamicSideContent.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,11 @@ <h1>Side Content</h1>
dynamicSideContent.accessibilityAttributes = {
mainContent: {
ariaLabel: "Main Content Area",
role: "region",
},
sideContent: {
ariaLabel: "Side Content Area",
role: "note",
}
};
</script>
Expand Down
Loading