feat(ui5-dynamic-side-content): add 'role' property to accessibilityAttributes object#13476
Draft
NHristov-sap wants to merge 2 commits intomainfrom
Draft
feat(ui5-dynamic-side-content): add 'role' property to accessibilityAttributes object#13476NHristov-sap wants to merge 2 commits intomainfrom
NHristov-sap wants to merge 2 commits intomainfrom
Conversation
NHristov-sap
changed the title
Collaborator
|
🚀 Deployed on https://pr-13476--ui5-webcomponents-preview.netlify.app |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Until now, there were hardcoded roles for main (role="main") and side (role="complementary") containers of the
ui5-dynamic-side-contentcomponent. In general case that is fine, but there are use cases where the component is placed in another landscape component that already has role="main" attribute, which produces Accessibility issues.This PR introduces new property
rolein theaccessibilityAttributesobject of the component both for main and side containers (with fallback to currently existing values if there is no other specified). That way, the developer can set another value if the use case requires such change.