Skip to content

chore(http): remove subscriptions restart endpoint #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yordis merged 1 commit into from
May 3, 2026
Merged

chore(http): remove subscriptions restart endpoint #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/EventStore.Core.Tests/swagger.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,11 +132,6 @@ paths:
responses:
"200":
description: OK
/subscriptions/restart:
post:
responses:
"200":
description: OK
/users:
get:
responses:
Expand Down
20 changes: 0 additions & 20 deletions src/EventStore.Core/Services/Transport/Http/Controllers/PersistentSubscriptionController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,6 @@ public PersistentSubscriptionController(IHttpForwarder httpForwarder, IPublisher
protected override void SubscribeCore(IHttpService service) {
Register(service, "/subscriptions?offset={offset}&count={count}", HttpMethod.Get, GetAllSubscriptionInfo, Codec.NoCodecs, DefaultCodecs, new Operation(Operations.Subscriptions.Statistics));
Register(service, "/subscriptions", HttpMethod.Get, GetAllSubscriptionInfo, Codec.NoCodecs, DefaultCodecs, new Operation(Operations.Subscriptions.Statistics));
Register(service, "/subscriptions/restart", HttpMethod.Post, RestartPersistentSubscriptions, Codec.NoCodecs, DefaultCodecs, new Operation(Operations.Subscriptions.Restart));
Register(service, "/subscriptions/{stream}", HttpMethod.Get, GetSubscriptionInfoForStream, Codec.NoCodecs,
DefaultCodecs, new Operation(Operations.Subscriptions.Statistics));
Register(service, "/subscriptions/{stream}/{subscription}", HttpMethod.Put, PutSubscription, DefaultCodecs,
Expand Down Expand Up @@ -373,25 +372,6 @@ private void DeleteSubscription(HttpEntityManager http, UriTemplateMatch match)
Publish(cmd);
}

private void RestartPersistentSubscriptions(HttpEntityManager http, UriTemplateMatch match) {
if (_httpForwarder.ForwardRequest(http))
return;

var envelope = new SendToHttpEnvelope<SubscriptionMessage.PersistentSubscriptionsRestarting>(_networkSendQueue, http,
(e, message) => e.To("Restarting"),
(e, message) => {
switch (message) {
case SubscriptionMessage.PersistentSubscriptionsRestarting _:
return Configure.Ok(e.ContentType);
default:
return Configure.InternalServerError();
}
}, CreateErrorEnvelope(http)
);

Publish(new SubscriptionMessage.PersistentSubscriptionsRestart(envelope));
}

private void GetAllSubscriptionInfo(HttpEntityManager http, UriTemplateMatch match) {
if (_httpForwarder.ForwardRequest(http))
return;
Expand Down
Loading