Skip to content

chore(http): remove subscriptions restart endpoint#158

Merged
yordis merged 1 commit intomasterfrom
yordis/chore-remove-subscriptions-restart-http
May 3, 2026
Merged

chore(http): remove subscriptions restart endpoint#158
yordis merged 1 commit intomasterfrom
yordis/chore-remove-subscriptions-restart-http

Conversation

@yordis
Copy link
Copy Markdown
Member

@yordis yordis commented May 3, 2026

  • Persistent subscription restart already has gRPC management coverage, so keeping the duplicate HTTP route preserves an avoidable programmatic surface.
  • Programmatic management should converge on gRPC where parity exists, leaving HTTP for UI, probes, metrics, and documented gaps.

Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@cursor
Copy link
Copy Markdown

cursor Bot commented May 3, 2026

PR Summary

Medium Risk
Removes an existing HTTP management endpoint, which can break clients or tooling that still calls /subscriptions/restart, but does not change persistent-subscription runtime behavior itself.

Overview
Removes the HTTP API surface for restarting persistent subscriptions by deleting the POST /subscriptions/restart route and its RestartPersistentSubscriptions handler from PersistentSubscriptionController.

Updates the Swagger spec (swagger.yaml) to drop the /subscriptions/restart path so it is no longer documented/tested as part of the HTTP API.

Reviewed by Cursor Bugbot for commit ba03945. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 3, 2026

Warning

Rate limit exceeded

@yordis has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 8 minutes and 54 seconds before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 70a945f8-6341-42d7-9f98-57c5daed1f16

📥 Commits

Reviewing files that changed from the base of the PR and between 16282f4 and ba03945.

📒 Files selected for processing (2)
  • src/EventStore.Core.Tests/swagger.yaml
  • src/EventStore.Core/Services/Transport/Http/Controllers/PersistentSubscriptionController.cs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch yordis/chore-remove-subscriptions-restart-http

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 8 minutes and 54 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

@yordis yordis merged commit fea3881 into master May 3, 2026
18 checks passed
@yordis yordis deleted the yordis/chore-remove-subscriptions-restart-http branch May 3, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant