Skip to content

fix(mobile): hide dock toggle and remove language selector flags on mobile viewports #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ThisIs-Developer merged 1 commit into from
May 27, 2026
Merged

fix(mobile): hide dock toggle and remove language selector flags on mobile viewports #124

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions desktop-app/resources/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,10 +297,10 @@ <h5>Menu</h5>
<i class="bi bi-translate me-2"></i> Language: <span id="mobile-current-lang-label">English</span>
</button>
<ul class="dropdown-menu w-100" aria-labelledby="mobileLanguageDropdown">
<li><a class="dropdown-item lang-select-item active" href="#" data-lang="en">🇺🇸 English</a></li>
<li><a class="dropdown-item lang-select-item" href="#" data-lang="zh">🇨🇳 简体中文</a></li>
<li><a class="dropdown-item lang-select-item" href="#" data-lang="ja">🇯🇵 日本語</a></li>
<li><a class="dropdown-item lang-select-item" href="#" data-lang="ko">🇰🇷 한국어</a></li>
<li><a class="dropdown-item lang-select-item active" href="#" data-lang="en">English</a></li>
<li><a class="dropdown-item lang-select-item" href="#" data-lang="zh">简体中文</a></li>
<li><a class="dropdown-item lang-select-item" href="#" data-lang="ja">日本語</a></li>
<li><a class="dropdown-item lang-select-item" href="#" data-lang="ko">한국어</a></li>
</ul>
</div>
<button id="mobile-theme-toggle" class="mobile-menu-item" title="Toggle Dark Mode">
Expand Down
45 changes: 41 additions & 4 deletions desktop-app/resources/js/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3953,12 +3953,33 @@ This is a fully client-side application. Your content never leaves your browser

let frPreferredDocked = false;

function toggleFrDockMode() {
function toggleFrDockMode(forceFloat = false) {
const panel = document.getElementById('find-replace-modal');
const dockBtn = document.getElementById('find-replace-dock');
const contentCont = document.querySelector('.content-container');
if (!panel || !dockBtn || !contentCont) return;

if (window.innerWidth <= 768 || forceFloat) {
isFrDocked = false;
panel.classList.remove('docked');
if (panel.parentElement !== document.body) {
document.body.appendChild(panel);
}
contentCont.classList.remove('fr-docked');
contentCont.style.setProperty('--dock-width', '0px');

panel.style.top = '';
panel.style.left = '';
panel.style.right = '';

dockBtn.innerHTML = '<i class="bi bi-layout-sidebar-reverse"></i>';
dockBtn.title = "Toggle Dock Mode";

panel.style.display = 'flex';
applyPaneWidths();
return;
}

isFrDocked = !isFrDocked;

// Save preference to localStorage
Expand Down Expand Up @@ -4119,7 +4140,12 @@ This is a fully client-side application. Your content never leaves your browser
}

// Restore docked/floating mode preference
const wasDockedPref = localStorage.getItem('find-replace-docked') === 'true';
let wasDockedPref = localStorage.getItem('find-replace-docked') === 'true';

// Force floating-only mode on mobile/tablet viewports
if (window.innerWidth <= 768) {
wasDockedPref = false;
}

if (wasDockedPref) {
isFrDocked = false; // Set false so toggleFrDockMode() turns it to true
Expand Down Expand Up @@ -4571,6 +4597,7 @@ This is a fully client-side application. Your content never leaves your browser
}

function startResize(e) {
if (window.innerWidth <= 768) return;
if (currentViewMode !== 'split') return;
e.preventDefault();
isResizing = true;
Expand All @@ -4579,6 +4606,7 @@ This is a fully client-side application. Your content never leaves your browser
}

function startResizeTouch(e) {
if (window.innerWidth <= 768) return;
if (currentViewMode !== 'split') return;
e.preventDefault();
isResizing = true;
Expand Down Expand Up @@ -4625,6 +4653,10 @@ This is a fully client-side application. Your content never leaves your browser
}

function applyPaneWidths() {
if (window.innerWidth <= 768) {
resetPaneWidths();
return;
}
if (currentViewMode !== 'split') return;

const previewPercent = 100 - editorWidthPercent;
Expand Down Expand Up @@ -4733,7 +4765,12 @@ This is a fully client-side application. Your content never leaves your browser

// Initialize resizer - Story 1.3
initResizer();
window.addEventListener('resize', scheduleLineNumberUpdate);
window.addEventListener('resize', () => {
scheduleLineNumberUpdate();
if (window.innerWidth <= 768 && isFrDocked && isFindModalOpen) {
toggleFrDockMode(true);
}
});

// View Mode Button Event Listeners - Story 1.1
viewModeButtons.forEach(btn => {
Expand Down Expand Up @@ -6648,7 +6685,7 @@ This is a fully client-side application. Your content never leaves your browser
}
const mobileLabelEl = document.getElementById('mobile-current-lang-label');
if (mobileLabelEl) {
const flags = { en: "🇺🇸 English", zh: "🇨🇳 简体中文", ja: "🇯🇵 日本語", ko: "🇰🇷 한국어" };
const flags = { en: "English", zh: "简体中文", ja: "日本語", ko: "한국어" };
mobileLabelEl.textContent = flags[lang];
}

Expand Down
17 changes: 17 additions & 0 deletions desktop-app/resources/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3376,4 +3376,21 @@ html[lang="ko"] .markdown-body h1, html[lang="ko"] .markdown-body h2, html[lang=
flex: 1;
position: relative;
overflow: hidden;
}

/* ========================================
MOBILE FIND PANEL RESPONSIVE FIXES
======================================== */
@media (max-width: 768px) {
#find-replace-dock {
display: none !important;
}

/* Prevent full screen expansion of floating panel on small mobile viewports */
.find-replace-panel {
width: calc(100% - 24px) !important;
right: 12px !important;
left: 12px !important;
top: 80px !important;
}
}
8 changes: 4 additions & 4 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,10 +294,10 @@ <h5>Menu</h5>
<i class="bi bi-translate me-2"></i> Language: <span id="mobile-current-lang-label">English</span>
</button>
<ul class="dropdown-menu w-100" aria-labelledby="mobileLanguageDropdown">
<li><a class="dropdown-item lang-select-item active" href="#" data-lang="en">🇺🇸 English</a></li>
<li><a class="dropdown-item lang-select-item" href="#" data-lang="zh">🇨🇳 简体中文</a></li>
<li><a class="dropdown-item lang-select-item" href="#" data-lang="ja">🇯🇵 日本語</a></li>
<li><a class="dropdown-item lang-select-item" href="#" data-lang="ko">🇰🇷 한국어</a></li>
<li><a class="dropdown-item lang-select-item active" href="#" data-lang="en">English</a></li>
<li><a class="dropdown-item lang-select-item" href="#" data-lang="zh">简体中文</a></li>
<li><a class="dropdown-item lang-select-item" href="#" data-lang="ja">日本語</a></li>
<li><a class="dropdown-item lang-select-item" href="#" data-lang="ko">한국어</a></li>
</ul>
</div>
<button id="mobile-theme-toggle" class="mobile-menu-item" title="Toggle Dark Mode">
Expand Down
45 changes: 41 additions & 4 deletions script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3953,12 +3953,33 @@ This is a fully client-side application. Your content never leaves your browser

let frPreferredDocked = false;

function toggleFrDockMode() {
function toggleFrDockMode(forceFloat = false) {
const panel = document.getElementById('find-replace-modal');
const dockBtn = document.getElementById('find-replace-dock');
const contentCont = document.querySelector('.content-container');
if (!panel || !dockBtn || !contentCont) return;

if (window.innerWidth <= 768 || forceFloat) {
isFrDocked = false;
panel.classList.remove('docked');
if (panel.parentElement !== document.body) {
document.body.appendChild(panel);
}
contentCont.classList.remove('fr-docked');
contentCont.style.setProperty('--dock-width', '0px');

panel.style.top = '';
panel.style.left = '';
panel.style.right = '';

dockBtn.innerHTML = '<i class="bi bi-layout-sidebar-reverse"></i>';
dockBtn.title = "Toggle Dock Mode";

panel.style.display = 'flex';
applyPaneWidths();
return;
}

isFrDocked = !isFrDocked;

// Save preference to localStorage
Expand Down Expand Up @@ -4119,7 +4140,12 @@ This is a fully client-side application. Your content never leaves your browser
}

// Restore docked/floating mode preference
const wasDockedPref = localStorage.getItem('find-replace-docked') === 'true';
let wasDockedPref = localStorage.getItem('find-replace-docked') === 'true';

// Force floating-only mode on mobile/tablet viewports
if (window.innerWidth <= 768) {
wasDockedPref = false;
}

if (wasDockedPref) {
isFrDocked = false; // Set false so toggleFrDockMode() turns it to true
Expand Down Expand Up @@ -4571,6 +4597,7 @@ This is a fully client-side application. Your content never leaves your browser
}

function startResize(e) {
if (window.innerWidth <= 768) return;
if (currentViewMode !== 'split') return;
e.preventDefault();
isResizing = true;
Expand All @@ -4579,6 +4606,7 @@ This is a fully client-side application. Your content never leaves your browser
}

function startResizeTouch(e) {
if (window.innerWidth <= 768) return;
if (currentViewMode !== 'split') return;
e.preventDefault();
isResizing = true;
Expand Down Expand Up @@ -4625,6 +4653,10 @@ This is a fully client-side application. Your content never leaves your browser
}

function applyPaneWidths() {
if (window.innerWidth <= 768) {
resetPaneWidths();
return;
}
if (currentViewMode !== 'split') return;

const previewPercent = 100 - editorWidthPercent;
Expand Down Expand Up @@ -4733,7 +4765,12 @@ This is a fully client-side application. Your content never leaves your browser

// Initialize resizer - Story 1.3
initResizer();
window.addEventListener('resize', scheduleLineNumberUpdate);
window.addEventListener('resize', () => {
scheduleLineNumberUpdate();
if (window.innerWidth <= 768 && isFrDocked && isFindModalOpen) {
toggleFrDockMode(true);
}
});

// View Mode Button Event Listeners - Story 1.1
viewModeButtons.forEach(btn => {
Expand Down Expand Up @@ -6648,7 +6685,7 @@ This is a fully client-side application. Your content never leaves your browser
}
const mobileLabelEl = document.getElementById('mobile-current-lang-label');
if (mobileLabelEl) {
const flags = { en: "🇺🇸 English", zh: "🇨🇳 简体中文", ja: "🇯🇵 日本語", ko: "🇰🇷 한국어" };
const flags = { en: "English", zh: "简体中文", ja: "日本語", ko: "한국어" };
mobileLabelEl.textContent = flags[lang];
}

Expand Down
17 changes: 17 additions & 0 deletions styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3376,4 +3376,21 @@ html[lang="ko"] .markdown-body h1, html[lang="ko"] .markdown-body h2, html[lang=
flex: 1;
position: relative;
overflow: hidden;
}

/* ========================================
MOBILE FIND PANEL RESPONSIVE FIXES
======================================== */
@media (max-width: 768px) {
#find-replace-dock {
display: none !important;
}

/* Prevent full screen expansion of floating panel on small mobile viewports */
.find-replace-panel {
width: calc(100% - 24px) !important;
right: 12px !important;
left: 12px !important;
top: 80px !important;
}
}
Loading