fix(mobile): hide dock toggle and remove language selector flags on mobile viewports#124
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This Pull Request introduces a modern, feature-rich Find & Replace panel designed to replace the basic client-side overlay, matching industry standards. The solution is fully integrated into both the Web application and the NeutralinoJS Desktop app container, optimized with GFM AST-aware scoping, visual highlighting overlays, global hotkey interceptions, and a clean, responsive mobile adaptation.
Key Features Implemented
1. Find & Replace Engine & Core Logic
(?<name>...), index capture groups$1, lookaheads, lookbehinds, case-insensitive options, and whole-word bounding.$$markers or Mermaid diagram declarations) are blocked with a safe error warning.marked.lexerto map character offsets. Enables users to restrict searches to specific document types, including headings, code snippets, LaTeX blocks, Mermaid diagrams, or plain text.2. UI/UX & Layout Enhancements
3. Mobile View Optimizations
<= 768px), forcing the panel to open in a floating-only configuration.calc(100% - 24px)width on mobile screens to maintain editor visibility.<= 768pxusing native CSS.#mobile-current-lang-label) to ensure a compact, clutter-free mobile UI.Technical Refinements & Bug Fixes
Ctrl + F,Ctrl + H, andEscape) to the document-level, globally blocking default browser search overlays and focusing the custom panel.--dock-width(340pxwhen docked,0pxwhen floating) to adjust the flex-basis subtraction of the editor and preview panes.color: transparent !importantto overlay elements to prevent visual text-doubling/blurring. Integrated vertical offset calculations insideselectActiveMatch()to center active matches in the viewport.Verification & Compilation Outcomes
1. Isolated Unit Tests
We verified the search algorithms and engine mechanics in isolation using
test_engine.js:executeSearchsimple substring matching: PassedpreserveCasecapitalization parsing: Passed2. Shared Desktop Compilation
Ran the build compiler
node prepare.jsinside thedesktop-app/directory to successfully:script.js,styles.css, andindex.htmlchanges.desktop-app/resources/directories.