fix(lookat): Fix mouse anchor and direction issue for camera pitch

[xezon]

• Follow up for fix(lookat): Fix mouse anchor and direction issue for camera pitch #2421

This change is a follow up for #2421 which was not replicated to Generals.

[greptile-apps]

Greptile Summary

This PR ports three bug fixes from GeneralsMD (Zero Hour) to Generals (vanilla) in LookAtXlat.cpp, following up on #2421. The changes fix an inverted pitch direction when dragging the mouse, initialize the anchor position when pitch adjustment begins (preventing an immediate jump), and add DESTROY_MESSAGE to the FOV begin/end cases so those messages are properly consumed.

Confidence Score: 5/5

Safe to merge — all changes are faithful ports of verified fixes from the GeneralsMD sibling file.

All four changes align exactly with the already-merged GeneralsMD reference (PR #2421): the pitch sign flip, anchor initialisation, and two DESTROY_MESSAGE additions. No logic is introduced net-new, and no custom rules are violated.

No files require special attention.

Important Files Changed

Filename	Overview
Generals/Code/GameEngine/Source/GameClient/MessageStream/LookAtXlat.cpp	Four targeted fixes: inverted pitch sign corrected (+ → -), missing anchor init added for MSG_META_DEMO_BEGIN_ADJUST_PITCH, and missing DESTROY_MESSAGE added for both FOV begin/end cases — all matching the GeneralsMD reference.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Mouse Move Event] --> B{m_isPitching?}
    B -- Yes --> C["angle = Scale * (currentPos.y - anchor.y)"]
    C --> D["userSetPitch(getPitch() - angle)  fixed: was +"]
    D --> E[m_anchor = currentPos]

    F[MSG_META_DEMO_BEGIN_ADJUST_PITCH] --> G[m_isPitching = true]
    G --> H["m_anchor = m_currentPos  added: prevents jump on first move"]
    H --> I["disp = DESTROY_MESSAGE"]

    J[MSG_META_DEMO_BEGIN_ADJUST_FOV] --> K[m_isChangingFOV = true]
    K --> L[m_anchor = m_currentPos]
    L --> M["disp = DESTROY_MESSAGE  added: message now consumed"]

    N[MSG_META_DEMO_END_ADJUST_FOV] --> O[m_isChangingFOV = false]
    O --> P["disp = DESTROY_MESSAGE  added: message now consumed"]

Loading

_{Reviews (1): Last reviewed commit: "fix(lookat): Fix mouse anchor and direct..." | Re-trigger Greptile}

[Skyaero42]

Ok