fix(headless): Set DX8Wrapper_IsWindowed to false to suppress assertion dialogs during shutdown#2298
Open
bobtista wants to merge 4 commits intoTheSuperHackers:mainfrom
Open
Conversation
… suppress assertion dialogs during shutdown
|
| Filename | Overview |
|---|---|
| GeneralsMD/Code/GameEngine/Source/Common/CommandLine.cpp | Moved DX8Wrapper_IsWindowed initialization from WinMain into parseHeadless() for better code organization |
Last reviewed commit: 3e96876
Skyaero42
reviewed
Feb 21, 2026
xezon
reviewed
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DX8Wrapper_IsWindowedto false in headless mode soignoringAsserts()works - particularly during shutdown afterTheGlobalDatahas been destroyed.Testing
-replay test.rep -headless -ignoreAsserts)