build: Add clang-tidy checks and script

[bobtista]

This PR builds on @JohnsterID's work in PR #1580, fixing issues identified in that PR to enable clang-tidy static analysis for the project.

• Closes clang-tidy #1580

Clang-tidy doesnot work with our Pre-Compiled Headers, so we can just run cmake to disable them, then it works. Added a python script for convenience and for processing files in batches to avoid Windows command line character limits.

Usage:

# One-time setup (creates build/clang-tidy/ - just CMake config, no compilation)
cmake -B build/clang-tidy -DCMAKE_DISABLE_PRECOMPILE_HEADERS=ON -G Ninja

# Run clang-tidy (auto-uses build/clang-tidy)
python scripts/run-clang-tidy.py --include Core/Libraries/

# Or run clang-tidy directly
clang-tidy -p build/clang-tidy --checks="-*,modernize-use-nullptr" "file.cpp"

[OmniBlade]

Out of interest, why does this close the clang-format stuff? Clang-tidy and clang-format perform different functions as I understand it.

[Skyaero42]

Out of interest, why does this close the clang-format stuff? Clang-tidy and clang-format perform different functions as I understand it.

I was in the understanding the three closed PR's were replacable by this work - additionally they were also not worked on, I'm doing a clean up of older PR's.

But if I was mistaken, please open the other PR again (and remove it from the first-post here).

[bobtista]

This works for me on mac and windows: EDIT while it runs on mac, it lacks a lot of Windows specific stuff and will skip a ton of files. I've removed mac support from the script and docs. Use Windows

[OmniBlade]

In my testing it seems that a required cmake argument is missing from the command suggested by the help text.

[OmniBlade]

A general comment I have is while this does work, it does the file checking serially and could work much faster on multi core machines if it generated multiple clang-tidy processes. I've not worked with clang-tidy that much previously so I'm not sure how easy that is to accomplish.

[bobtista]

A general comment I have is while this does work, it does the file checking serially and could work much faster on multi core machines if it generated multiple clang-tidy processes. I've not worked with clang-tidy that much previously so I'm not sure how easy that is to accomplish.

Yeah I noticed this too - The script already supports parallelization via --jobs. It defaults to --jobs 1 (serial). Updating it to default to the number of CPU cores:

[OmniBlade]

I think that has addressed any issues I had. Only issue with running the script is that currently running it on anything more than a handful of files generates a lot of output to pour over.