Skip to content

Require dimension 3 for IFCARBITRARYPROFILEDEFWITHVOIDS #2018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
barvirm wants to merge 2 commits into
base: main
Choose a base branch
from
+3 −2
Open

Require dimension 3 for IFCARBITRARYPROFILEDEFWITHVOIDS #2018

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df18206
Require dimension 3 for IFCARBITRARYPROFILEDEFWITHVOIDS
May 29, 2026
ed36d4d
.
May 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/cpp/web-ifc/geometry/IfcGeometryLoader.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3150,15 +3150,16 @@ namespace webifc::geometry
_loader.MoveToArgumentOffset(expressID, 0);
profile.type = _loader.GetStringArgument();
_loader.MoveToArgumentOffset(expressID, 2);
profile.curve = GetCurve(_loader.GetRefArgument(), 2);
// ISSUE 1973 same as IFCARBITRARYCLOSEDPROFILEDEF: 3D curves require dimension 3
profile.curve = GetCurve(_loader.GetRefArgument(), 3);
profile.isConvex = IsCurveConvex(profile.curve);

_loader.MoveToArgumentOffset(expressID, 3);
auto holes = _loader.GetSetArgument();

for (auto &hole : holes)
{
IfcCurve holeCurve = GetCurve(_loader.GetRefArgument(hole), 2);
IfcCurve holeCurve = GetCurve(_loader.GetRefArgument(hole), 3);
profile.holes.push_back(holeCurve);
}

Expand Down