Require dimension 3 for IFCARBITRARYPROFILEDEFWITHVOIDS#2018
Open
barvirm wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue #1973
IFCARBITRARYPROFILEDEFWITHVOIDSwas callingGetCurve(..., 2)(dimensions=2) for both the outer boundary and void curves.When the profile boundary is defined by 3D curves (IFCCOMPOSITECURVE -> IFCTRIMMEDCURVE -> IFCLINE with 3D points),
the 2D code path calls
GetCartesianPoint2Dwhich reads only thexandycoordinates.This produces wrong geometry whenever the
zcomponent of the line origin is non-zero.IFCARBITRARYCLOSEDPROFILEDEFalready had the same fix applied (comment referencing issues #765 and #1604), butIFCARBITRARYPROFILEDEFWITHVOIDSwas missed.