Disable network table writing of akit logs when on a real field#674
Open
aschokking wants to merge 1 commit into
Open
Disable network table writing of akit logs when on a real field#674aschokking wants to merge 1 commit into
aschokking wants to merge 1 commit into
Conversation
Rongrrz
reviewed
May 15, 2026
Contributor
There was a problem hiding this comment.
Not too exact on NetworkTable nuances but here are my thoughts:
- Since this is outgoing data, in theory this shouldn't mess with anything Elastic/Shuffleboard/us changing properties on the NT side.
- I do agree that we could definitely lose out on current auto commands (a very immediate--easy--and inefficient solution imo is with system.out).
- We should also survey the drive team to see how often they utilize the live data (but I suppose not very often).
- Lastly: how would this affect if on the robot side we decide to change double properties with code using .set()? (It shouldn't affect anything, right?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are we doing this?
We have a hojillian values being written, which tends to tax the rio and the network.
I saw this line in 254s code which disables writing akit logs when fms is attached. It seems like a good idea in general.
The downside is that during a match we might want to be checking a value and won't be able to. For some crucial things like the current auto command we could be using some explicit overrides here maybe.
Whats changing?
Questions/notes for reviewers
How this was tested