chore(QTDI-2898): S1124 Modifier order

component-api/src/main/java/org/talend/sdk/component/api/service/discovery/DiscoverDatasetResult.java

@@ -35,7 +35,7 @@ public DiscoverDatasetResult(final List<DatasetDescription> datasetDescriptionLi
     }
 
     @Getter
-    public final static class DatasetDescription {
+    public static final class DatasetDescription {
 
         public DatasetDescription(final String name) {
             this.name = name;

component-form/component-uispec-mapper/src/test/java/org/talend/sdk/component/form/uispec/mapper/impl/UiSpecMapperImplTest.java

@@ -84,7 +84,7 @@ public Collection<UiSchema.NameValue> get() {
     }
 
     @Data
-    public static abstract class BaseModel {
+    public abstract static class BaseModel {
 
         @View.Skip
         private String id;

component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/TalendIO.java

@@ -109,7 +109,7 @@ public static Write write(final Processor output) {
         return new Write(output);
     }
 
-    public static abstract class Base<A extends PInput, B extends POutput, D extends Lifecycle>
+    public abstract static class Base<A extends PInput, B extends POutput, D extends Lifecycle>
             extends PTransform<A, B> {
 
         protected D delegate;

component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/record/AvroRecord.java

@@ -50,7 +50,7 @@
 
 public class AvroRecord implements Record, AvroPropertyMapper, Unwrappable {
 
-    public final static ZoneId UTC = ZoneId.of("UTC");
+    public static final ZoneId UTC = ZoneId.of("UTC");
 
     private static final RecordConverters RECORD_CONVERTERS = new RecordConverters();
 

component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/BeamIOWrappingTest.java

@@ -70,10 +70,10 @@
 public class BeamIOWrappingTest implements Serializable {
 
     @Rule
-    public transient final TestPipeline pipeline = TestPipeline.create();
+    public final transient TestPipeline pipeline = TestPipeline.create();
 
     @ClassRule
-    public static transient final TemporaryFolder TEMPORARY_FOLDER = new TemporaryFolder();
+    public static final transient TemporaryFolder TEMPORARY_FOLDER = new TemporaryFolder();
 
     @Test
     public void nativeBeamPipeline() {

component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/NativeWrappedIOTest.java

@@ -82,7 +82,7 @@ public class NativeWrappedIOTest {
                     .withIsolatedPackage(JdbcSource.class.getPackage().getName(), JdbcIO.class.getPackage().getName());
 
     @Rule
-    public transient final TestPipeline pipeline = TestPipeline.create();
+    public final transient TestPipeline pipeline = TestPipeline.create();
 
     @Test
     public void dofn() {

component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/TalendIOTest.java

@@ -79,7 +79,7 @@ public class TalendIOTest implements Serializable {
     private static final Jsonb JSONB = JsonbBuilder.create();
 
     @Rule
-    public transient final TestPipeline pipeline = TestPipeline.create();
+    public final transient TestPipeline pipeline = TestPipeline.create();
 
     @Test
     public void input() {
@@ -328,7 +328,7 @@ public static class SampleLength implements Serializable {
         private int len;
     }
 
-    private static abstract class BaseTestProcessor implements Serializable, Processor {
+    private abstract static class BaseTestProcessor implements Serializable, Processor {
 
         @Override
         public void beforeGroup() {
@@ -366,7 +366,7 @@ public void stop() {
         }
     }
 
-    private static abstract class BaseTestInput implements Serializable, Input {
+    private abstract static class BaseTestInput implements Serializable, Input {
 
         @Override
         public String plugin() {
@@ -394,7 +394,7 @@ public void stop() {
         }
     }
 
-    private static abstract class TheTestMapper implements Serializable, Mapper {
+    private abstract static class TheTestMapper implements Serializable, Mapper {
 
         @Override
         public boolean isStream() {

component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/chain/BeamJobTest.java

@@ -43,7 +43,7 @@
 @Slf4j
 class BeamJobTest implements Serializable {
 
-    private transient final PluginGenerator pluginGenerator = new PluginGenerator();
+    private final transient PluginGenerator pluginGenerator = new PluginGenerator();
 
     @Test
     void complex(final TestInfo info, @TempDir final Path temporaryFolder) throws IOException {

component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java

@@ -1302,7 +1302,7 @@
             }
         };
 
-        abstract public Map<String, ? extends ComponentFamilyMeta.BaseMeta> findMeta(ComponentFamilyMeta family);
+        public abstract Map<String, ? extends ComponentFamilyMeta.BaseMeta> findMeta(ComponentFamilyMeta family);
 
         abstract Class<? extends Lifecycle> runtimeType();
     }

component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/http/ExecutionContext.java

@@ -226,7 +226,7 @@ public Object decode(final byte[] value, final Type expectedType) {
     }
 
     @AllArgsConstructor
-    private static abstract class BaseResponse<T> implements Response<T> {
+    private abstract static class BaseResponse<T> implements Response<T> {
 
         private final int status;
 

component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/http/RequestParser.java

@@ -93,7 +93,7 @@ interface InstanceCreator {
     }
 
     @AllArgsConstructor
-    final static class ReflectionInstanceCreator implements InstanceCreator {
+    static final class ReflectionInstanceCreator implements InstanceCreator {
 
         private final ReflectionService reflections;
 

component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/ServiceHelperTest.java

@@ -44,10 +44,10 @@ void generate() throws NoSuchMethodException {
     }
 
     @Service
-    static public class Service1 {
+    public static class Service1 {
     }
 
     @Service
-    static public class Service2 extends BaseService {
+    public static class Service2 extends BaseService {
     }
 }

component-runtime-manager/src/test/java/org/talend/test/DataInput.java

@@ -76,7 +76,7 @@ public class DataInput implements Serializable {
 
     private final String tableName;
 
-    public DataInput(final @Option("tableName") String tableName, final Jsonb jsonb, final I18nService i18n) {
+    public DataInput(@Option("tableName") final String tableName, final Jsonb jsonb, final I18nService i18n) {
         this.tableName = tableName;
         this.jsonb = jsonb;
         this.i18n = i18n;

component-runtime-manager/src/test/java/org/talend/test/MapperWithCheckpoint.java

@@ -50,7 +50,7 @@ public class MapperWithCheckpoint implements Serializable {
 
     private int partition = -1;
 
-    public MapperWithCheckpoint(final @Option("configuration") MapperWithCheckpointConfig config,
+    public MapperWithCheckpoint(@Option("configuration") final MapperWithCheckpointConfig config,
             final RecordBuilderFactory recordBuilderFactory) {
         this.config = config;
         this.recordBuilderFactory = recordBuilderFactory;

component-runtime-testing/component-runtime-beam-junit/src/test/java/org/talend/sdk/component/junit/beam/ProcessorTest.java

@@ -50,7 +50,7 @@ public class ProcessorTest {
             new SimpleComponentRule(SampleProcessor.class.getPackage().getName());
 
     @Rule
-    public transient final TestPipeline pipeline = TestPipeline.create();
+    public final transient TestPipeline pipeline = TestPipeline.create();
 
     @Test
     public void processor() {

component-runtime-testing/component-runtime-beam-junit/src/test/java/org/talend/sdk/component/junit/beam/test/SampleProcessor.java

@@ -31,8 +31,8 @@
 public class SampleProcessor implements Serializable {
 
     @ElementListener
-    public void onNext(final @Input Sample sample, final @Output OutputEmitter<Sample> success,
-            final @Output("reject") OutputEmitter<Reject> reject) {
+    public void onNext(@Input final Sample sample, @Output final OutputEmitter<Sample> success,
+            @Output("reject") final OutputEmitter<Reject> reject) {
 
         success.emit(sample);
         reject.emit(new Reject(sample, "error"));

component-runtime-testing/component-runtime-testing-spark/src/main/java/org/talend/sdk/component/runtime/testing/spark/internal/BaseSpark.java

@@ -102,7 +102,7 @@ public abstract class BaseSpark<T extends BaseSpark<?>> {
 
     protected abstract File getRoot();
 
-    protected final static String EXTRA_JVM_ARGS =
+    protected static final String EXTRA_JVM_ARGS =
             "--add-opens=java.base/java.nio=ALL-UNNAMED --add-opens=java.base/sun.nio.ch=ALL-UNNAMED";
 
     public T withSlaves(final int slaves) {

component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/test/migration/MigrationDataSet.java

@@ -28,7 +28,7 @@
 @Version(migrationHandler = AbstractMigrationHandler.DataSetHandler.class)
 public class MigrationDataSet implements Serializable {
 
-    public final static int Version = -1;
+    public static final int Version = -1;
 
     @Option
     private final MigrationDataStore dataStore;

component-starter-server/src/main/resources/generator/facet/beam/BeamProcessorTest.mustache

@@ -37,7 +37,7 @@ public class {{testClassName}} {
     public static final SimpleComponentRule COMPONENT_FACTORY = new SimpleComponentRule("{{rootPackage}}");
 
     @Rule
-    public transient final TestPipeline pipeline = TestPipeline.create();
+    public final transient TestPipeline pipeline = TestPipeline.create();
 
     @Test
     @Ignore("You need to complete this test with your own data and assertions")

component-starter-server/src/main/resources/generator/facet/beam/BeamSourceTest.mustache

@@ -22,7 +22,7 @@ public class {{testClassName}} implements Serializable {
     public static final SimpleComponentRule COMPONENT_FACTORY = new SimpleComponentRule("{{rootPackage}}");
 
     @Rule
-    public transient final TestPipeline pipeline = TestPipeline.create();
+    public final transient TestPipeline pipeline = TestPipeline.create();
 
     @Test
     @Ignore("You need to complete this test with your own data and assertions")

component-starter-server/src/test/java/org/talend/sdk/component/starter/server/front/apidemo/component/output/MockOutput.java

@@ -66,8 +66,8 @@
     }
 
     @ElementListener
-    public void onNext(@Input final JsonObject record, final @Output OutputEmitter<JsonObject> success,
-            final @Output("reject") OutputEmitter<Reject> reject) {
+    public void onNext(@Input final JsonObject record, @Output final OutputEmitter<JsonObject> success,
+            @Output("reject") final OutputEmitter<Reject> reject) {
         try {
             JsonObject newRec;
             String sysId = null;

component-starter-server/src/test/resources/generated/ProjectResourceTest/beamFacet/TInMapperBeamTest.java

@@ -22,7 +22,7 @@ public class TInMapperBeamTest implements Serializable {
     public static final SimpleComponentRule COMPONENT_FACTORY = new SimpleComponentRule("com.foo");
 
     @Rule
-    public transient final TestPipeline pipeline = TestPipeline.create();
+    public final transient TestPipeline pipeline = TestPipeline.create();
 
     @Test
     @Ignore("You need to complete this test with your own data and assertions")

component-starter-server/src/test/resources/generated/ProjectResourceTest/beamFacet/TInOutputBeamTest.java

@@ -22,7 +22,7 @@ public class TInOutputBeamTest {
     public static final SimpleComponentRule COMPONENT_FACTORY = new SimpleComponentRule("com.foo");
 
     @Rule
-    public transient final TestPipeline pipeline = TestPipeline.create();
+    public final transient TestPipeline pipeline = TestPipeline.create();
 
     @Test
     @Ignore("You need to complete this test with your own data and assertions")

component-starter-server/src/test/resources/generated/ProjectResourceTest/beamFacetProcessorOutput/TInProcessorBeamTest.java

@@ -29,7 +29,7 @@ public class TInProcessorBeamTest {
     public static final SimpleComponentRule COMPONENT_FACTORY = new SimpleComponentRule("com.foo");
 
     @Rule
-    public transient final TestPipeline pipeline = TestPipeline.create();
+    public final transient TestPipeline pipeline = TestPipeline.create();
 
     @Test
     @Ignore("You need to complete this test with your own data and assertions")

component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/beam/InMemoryQueueIOTest.java

@@ -50,7 +50,7 @@ public class InMemoryQueueIOTest implements Serializable {
     private static final Collection<Record> INPUT_OUTPUTS = new CopyOnWriteArrayList<>();
 
     @Rule
-    public transient final TestPipeline pipeline =
+    public final transient TestPipeline pipeline =
             TestPipeline.fromOptions(PipelineOptionsFactory.fromArgs("--blockOnRun=false").create());
 
     @Test(timeout = 60000)

component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchemaTest.java

@@ -88,7 +88,7 @@ class TaCoKitGuessSchemaTest {
 
     private final Pattern logPattern = Pattern.compile("^\\[\\s*(INFO|WARN|ERROR|DEBUG|TRACE)\\s*]");
 
-    private final static java.io.PrintStream stdout = System.out;
+    private static final java.io.PrintStream stdout = System.out;
 
     @BeforeAll
     static void forceManagerInit() {

component-tools/src/test/java/org/talend/sdk/component/tools/validator/ActionValidatorTest.java

@@ -296,13 +296,13 @@ public Schema guessProcessorSchemaKo0() {
         }
 
         @DiscoverSchemaExtended("schema")
-        public Schema guessProcessorSchemaKo1(final Schema schema, final @Option FakeDataSet configuration,
+        public Schema guessProcessorSchemaKo1(final Schema schema, @Option final FakeDataSet configuration,
                 final String outgoing) {
             return null;
         }
 
         @DiscoverSchemaExtended("schema")
-        public Schema guessProcessorSchemaKo2(final Schema schema, final @Option FakeDataSet configuration,
+        public Schema guessProcessorSchemaKo2(final Schema schema, @Option final FakeDataSet configuration,
                 final String outgoing) {
             return null;
         }

component-tools/src/test/java/org/talend/test/failure/aftergroup/MyComponent.java

@@ -48,7 +48,7 @@ public void beforeGroup() {
     }
 
     @ElementListener
-    public Foo passthrough(final Foo item, final @Output("out1") OutputEmitter<JsonObject> out) {
+    public Foo passthrough(final Foo item, @Output("out1") final OutputEmitter<JsonObject> out) {
         return item;
     }
 

component-tools/src/test/java/org/talend/test/failure/aftergroup/MyComponent2.java

@@ -48,12 +48,12 @@
     }
 
     @ElementListener
-    public Foo passthrough(final Foo item, final @Output("out1") OutputEmitter<JsonObject> out) {
+    public Foo passthrough(final Foo item, @Output("out1") final OutputEmitter<JsonObject> out) {
         return item;
     }
 
     @AfterGroup
-    public void afterGroup(final @Output JsonObject data) {
+    public void afterGroup(@Output final JsonObject data) {
 
     }
 

component-tools/src/test/java/org/talend/test/failure/aftergroup/MyComponent3.java

@@ -48,12 +48,12 @@
     }
 
     @ElementListener
-    public Foo passthrough(final Foo item, final @Output("out1") OutputEmitter<JsonObject> out) {
+    public Foo passthrough(final Foo item, @Output("out1") final OutputEmitter<JsonObject> out) {
         return item;
     }
 
     @AfterGroup
-    public void afterGroup(final @Output OutputEmitter<JsonObject> out1, JsonObject out2) {
+    public void afterGroup(@Output final OutputEmitter<JsonObject> out1, JsonObject out2) {
 
     }
 

component-tools/src/test/java/org/talend/test/failure/aftergroup/MyComponent4.java

@@ -49,7 +49,7 @@ public void beforeGroup() {
     }
 
     @ElementListener
-    public Foo passthrough(final Foo item, final @Output("out1") OutputEmitter<JsonObject> out) {
+    public Foo passthrough(final Foo item, @Output("out1") final OutputEmitter<JsonObject> out) {
         return item;
     }
 

component-tools/src/test/java/org/talend/test/failure/aftergroup/MyComponent5.java

@@ -49,7 +49,7 @@ public void beforeGroup() {
     }
 
     @ElementListener
-    public Foo passthrough(final Foo item, final @Output("out1") OutputEmitter<JsonObject> out) {
+    public Foo passthrough(final Foo item, @Output("out1") final OutputEmitter<JsonObject> out) {
         return item;
     }
 

component-tools/src/test/java/org/talend/test/failure/aftergroup/MyComponent6.java

@@ -41,7 +41,7 @@ public MyComponent6(@Option("configuration") final MyConfig config) {
     }
 
     @ElementListener
-    public Foo passthrough(final Foo item, final @Output("out1") OutputEmitter<JsonObject> out) {
+    public Foo passthrough(final Foo item, @Output("out1") final OutputEmitter<JsonObject> out) {
         return item;
     }
 

documentation/src/main/antora/modules/ROOT/pages/documentation-rest.adoc

@@ -383,7 +383,7 @@ public Ui getNewComponentModelForm() {
 
 @GET
 @Path("{id}")
-public Ui editComponentModelForm(final @PathParam("id") final String id) {
+public Ui editComponentModelForm(@PathParam("id") final String id) {
     final ComponentModel component = findComponent(id);
     final Ui spec = getNewComponentModelForm();
     spec.setProperties(component);

documentation/src/main/antora/modules/ROOT/pages/studio-schema.adoc

@@ -187,7 +187,7 @@ Prototype:
  * @return
  */
 @DiscoverSchemaExtended("full")
-public Schema guessMethodName(final Schema incomingSchema, final @Option("configuration") ConfigClass myConfig, final String branch) {...}
+public Schema guessMethodName(final Schema incomingSchema, @Option("configuration") final ConfigClass myConfig, final String branch) {...}
 
 @DiscoverSchemaExtended("incoming_schema")
 public Schema guessMethodName(final Schema incomingSchema, final @Option("configuration") ConfigClass myConfig) {...}

documentation/src/main/java/org/talend/runtime/documentation/component/output/MockOutput.java

@@ -66,8 +66,8 @@ public void init() {
     }
 
     @ElementListener
-    public void onNext(@Input final JsonObject record, final @Output OutputEmitter<JsonObject> success,
-            final @Output("reject") OutputEmitter<Reject> reject) {
+    public void onNext(@Input final JsonObject record, @Output final OutputEmitter<JsonObject> success,
+            @Output("reject") final OutputEmitter<Reject> reject) {
         try {
             JsonObject newRec;
             String sysId = null;

sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/config/InputConfig.java

@@ -41,7 +41,7 @@
                 @GridLayout.Row({ "dataset" }) })
 public class InputConfig implements Serializable {
 
-    public final static int INPUT_CONFIG_VERSION = 3;
+    public static final int INPUT_CONFIG_VERSION = 3;
 
     @Option
     @Documentation("Doc: default dataset documentation without Internationalization.")