chore(QTDI-2898): S1124 Modifier order

[undx]

https://qlik-dev.atlassian.net/browse/QTDI-2898

AI generated code

https://internal.qlik.dev/general/ways-of-working/code-reviews/#guidelines-for-ai-generated-code

• [] this PR has been written with the help of GitHub Copilot or another generative AI tool

[Copilot]

Pull request overview

This PR primarily standardizes Java modifier/annotation ordering across multiple modules to satisfy rule S1124 (“Modifier order”), covering both production and test/sample code, plus a couple documentation/frontend artifacts.

Changes:

• Reordered Java modifiers (e.g., public static final, abstract static, final transient) and parameter annotation placement for consistency/S1124 compliance.
• Updated multiple sample/test components and documentation code snippets to reflect the same ordering.
• Updated documentation frontend package-lock.json metadata (but currently introduces a version mismatch—see comments).

Reviewed changes

Copilot reviewed 57 out of 61 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
sample-parent/sample-features/loading-analysis/loading-services-and-resources/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withspi/service/DynamicDependenciesWithSPIService.java	Reorders parameter annotation/modifier in schema discovery method signature.
sample-parent/sample-features/loading-analysis/loading-dependencies-with-dynamicDependenciesConfiguration/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withDynamicDependenciesConfiguration/service/DynamicDependenciesWithDynamicDependenciesConfigurationService.java	Reorders constant modifiers and parameter annotation/modifier order.
sample-parent/sample-features/loading-analysis/loading-dependencies-with-datastore/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withdatastore/service/DynamicDependenciesWithDatastoreService.java	Reorders constant modifiers and parameter annotation/modifier order.
sample-parent/sample-features/loading-analysis/loading-dependencies-with-dataset/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withdataset/service/DynamicDependenciesWithDatasetService.java	Reorders constant modifiers and parameter annotation/modifier order.
sample-parent/sample-features/loading-analysis/loading-dependencies-with-dataprepRunAnnotation/src/main/java/org/talend/sdk/component/sample/feature/loadinganalysis/withDataprepRunAnnotation/service/DynamicDependenciesDataprepRunAnnotationService.java	Reorders constant modifiers and parameter annotation/modifier order.
sample-parent/sample-features/fixed-schema/src/main/java/org/talend/sdk/component/sample/feature/fixedschema/service/UIService.java	Reorders constants and parameter annotation/modifier order in schema discovery method.
sample-parent/sample-features/entry-with-error/src/main/java/org/talend/sdk/component/sample/feature/entrywitherror/RecordWithEntriesInErrorEmitter.java	Reorders constructor parameter annotation/modifier order.
sample-parent/sample-features/database-mapping/src/main/java/org/talend/sdk/component/sample/feature/databasemapping/service/UIService.java	Reorders method parameter annotation/modifier order and alignment.
sample-parent/sample-features/configuration-form/src/main/java/org/talend/sdk/component/feature/form/service/UIService.java	Reorders constant modifiers to public static final.
sample-parent/sample-features/conditional-outputs/src/main/java/org/talend/sdk/component/sample/feature/availableoutput/service/AvailableOutputService.java	Reorders parameter annotation/modifier order in action methods.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/service/UserServices.java	Reorders constant modifiers to public static final.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/service/SchemaServices.java	Reorders multiple action constants and parameter annotation/modifier ordering in schema methods.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/service/HealthcheckServices.java	Reorders action constant modifiers.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/service/DynamicValuesServices.java	Reorders action constant modifiers.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/service/DiscoverDatasetServices.java	Reorders action constant modifiers.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/service/CreateConnectionServices.java	Reorders action constant modifiers.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/service/CloseConnectionServices.java	Reorders action constant modifiers.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/service/BuiltInSuggestableServices.java	Reorders action constant modifiers.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/service/ActionsServices.java	Reorders action constants and update method parameter annotation/modifier order.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/output/TheOutput1.java	Reorders constructor parameter annotation/modifier order.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/input/TheMapper1.java	Reorders constructor parameter annotation/modifier order and indentation.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/input/TheInput1.java	Reorders constructor parameter annotation/modifier order and indentation.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/config/TheDatastore.java	Reorders constant modifiers.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/config/TheDataset.java	Reorders constant modifiers.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/config/OutputConfig.java	Reorders constant modifiers.
sample-parent/sample-connector/src/main/java/org/talend/sdk/component/test/connectors/config/InputConfig.java	Reorders constant modifiers.
documentation/src/main/java/org/talend/runtime/documentation/component/output/MockOutput.java	Reorders parameter annotation/modifier order in @ElementListener method.
documentation/src/main/frontend/package-lock.json	Updates lockfile metadata version fields (currently inconsistent with Maven project version).
documentation/src/main/antora/modules/ROOT/pages/studio-schema.adoc	Updates documentation example signature to reflect new annotation/modifier ordering.
documentation/src/main/antora/modules/ROOT/pages/documentation-rest.adoc	Updates documentation example signature (currently introduces final final).
component-tools/src/test/java/org/talend/test/failure/aftergroup/MyComponent6.java	Reorders @Output parameter annotation/modifier order.
component-tools/src/test/java/org/talend/test/failure/aftergroup/MyComponent5.java	Reorders @Output parameter annotation/modifier order.
component-tools/src/test/java/org/talend/test/failure/aftergroup/MyComponent4.java	Reorders @Output parameter annotation/modifier order.
component-tools/src/test/java/org/talend/test/failure/aftergroup/MyComponent3.java	Reorders @Output parameter annotation/modifier order in @ElementListener/@AfterGroup.
component-tools/src/test/java/org/talend/test/failure/aftergroup/MyComponent2.java	Reorders @Output parameter annotation/modifier order in @ElementListener/@AfterGroup.
component-tools/src/test/java/org/talend/test/failure/aftergroup/MyComponent.java	Reorders @Output parameter annotation/modifier order.
component-tools/src/test/java/org/talend/sdk/component/tools/validator/ActionValidatorTest.java	Reorders parameter annotation/modifier order in validator test fixtures.
component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/schema/TaCoKitGuessSchemaTest.java	Reorders static field modifiers.
component-studio/component-runtime-di/src/test/java/org/talend/sdk/component/runtime/di/beam/InMemoryQueueIOTest.java	Reorders JUnit @Rule field modifiers (final transient).
component-starter-server/src/test/resources/generated/ProjectResourceTest/beamFacetProcessorOutput/TInProcessorBeamTest.java	Reorders generated test @Rule field modifiers.
component-starter-server/src/test/resources/generated/ProjectResourceTest/beamFacet/TInOutputBeamTest.java	Reorders generated test @Rule field modifiers.
component-starter-server/src/test/resources/generated/ProjectResourceTest/beamFacet/TInMapperBeamTest.java	Reorders generated test @Rule field modifiers.
component-starter-server/src/test/java/org/talend/sdk/component/starter/server/front/apidemo/component/output/MockOutput.java	Reorders parameter annotation/modifier order in @ElementListener method.
component-server-parent/component-server/src/test/java/org/talend/sdk/component/server/test/migration/MigrationDataSet.java	Reorders constant modifiers.
component-runtime-testing/component-runtime-testing-spark/src/main/java/org/talend/sdk/component/runtime/testing/spark/internal/BaseSpark.java	Reorders constant modifiers.
component-runtime-testing/component-runtime-beam-junit/src/test/java/org/talend/sdk/component/junit/beam/test/SampleProcessor.java	Reorders parameter annotation/modifier order in @ElementListener method.
component-runtime-testing/component-runtime-beam-junit/src/test/java/org/talend/sdk/component/junit/beam/ProcessorTest.java	Reorders JUnit @Rule field modifiers.
component-runtime-manager/src/test/java/org/talend/test/MapperWithCheckpoint.java	Reorders constructor parameter annotation/modifier order and indentation.
component-runtime-manager/src/test/java/org/talend/test/DataInput.java	Reorders constructor parameter annotation/modifier order.
component-runtime-manager/src/test/java/org/talend/sdk/component/runtime/manager/service/ServiceHelperTest.java	Reorders nested class modifiers (public static).
component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/http/RequestParser.java	Reorders nested class modifiers (static final).
component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/service/http/ExecutionContext.java	Reorders nested class modifiers (abstract static).
component-runtime-manager/src/main/java/org/talend/sdk/component/runtime/manager/ComponentManager.java	Reorders method modifiers (public abstract).
component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/TalendIOTest.java	Reorders @Rule field modifiers and nested abstract class modifiers.
component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/NativeWrappedIOTest.java	Reorders @Rule field modifiers.
component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/chain/BeamJobTest.java	Reorders field modifiers (final transient).
component-runtime-beam/src/test/java/org/talend/sdk/component/runtime/beam/BeamIOWrappingTest.java	Reorders @Rule/@ClassRule field modifiers.
component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/TalendIO.java	Reorders nested abstract class modifiers (abstract static).
component-runtime-beam/src/main/java/org/talend/sdk/component/runtime/beam/spi/record/AvroRecord.java	Reorders constant modifiers.
component-form/component-uispec-mapper/src/test/java/org/talend/sdk/component/form/uispec/mapper/impl/UiSpecMapperImplTest.java	Reorders nested abstract class modifiers (abstract static).
component-api/src/main/java/org/talend/sdk/component/api/service/discovery/DiscoverDatasetResult.java	Reorders nested class modifiers (static final).

Files not reviewed (1)

• documentation/src/main/frontend/package-lock.json: Language not supported

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

Pull request overview

Copilot reviewed 59 out of 62 changed files in this pull request and generated no new comments.

[sonar-rnd]

Quality Gate failed

• 0.00% Coverage on New Code (is less than 80.00%)
• 7 New Issues (is greater than 0)

Project ID: org.talend.sdk.component:component-runtime

View in SonarQube