Skip to content

fix: #163 2차QA 반영 #166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sum130 wants to merge 1 commit into
base: develop
Choose a base branch
from
+16 −300
Open

fix: #163 2차QA 반영 #166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions ...rish-iOS/Cherrish-iOS/Presentation/Feature/ChallengeView/View/ChallengeProgressView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,7 @@ extension ChallengeProgressView {
}
.padding(.horizontal, 25.adjustedW)
}
.frame(width: 326.adjustedW, height: 320.adjustedH)
Copy link

@coderabbitai coderabbitai bot Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

고정 높이로 인한 텍스트/이미지 클리핑 가능성
다이나믹 타입 확대나 문구 길이 변화 시 내부 콘텐츠가 잘릴 수 있어요. 최소 높이로 두고 확장되도록 여지를 두는 편이 안전합니다.

🛠️ 제안 수정안 
-        .frame(width: 326.adjustedW, height: 320.adjustedH)
+        .frame(width: 326.adjustedW, minHeight: 320.adjustedH, alignment: .top)
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
.frame(width: 326.adjustedW, height: 320.adjustedH)
.frame(width: 326.adjustedW, minHeight: 320.adjustedH, alignment: .top)
🤖 Prompt for AI Agents 
In
`@Cherrish-iOS/Cherrish-iOS/Presentation/Feature/ChallengeView/View/ChallengeProgressView.swift`
at line 128, The view uses a fixed height via the .frame(width: 326.adjustedW,
height: 320.adjustedH) modifier in ChallengeProgressView which can cause
text/image clipping with Dynamic Type or variable content; remove the hard-coded
height and make the layout flexible by replacing the fixed height with a minimum
height or flexible constraints (e.g., use .frame(width: 326.adjustedW,
minHeight: 320.adjustedH) or .frame(maxHeight: .infinity) and/or add
.fixedSize(horizontal: false, vertical: true) so the content can expand; update
the modifier applied to the view in ChallengeProgressView to use
minHeight/maxHeight or flexible sizing instead of the hard-coded height.

.padding(.top, 16.adjustedH)
.background(
RoundedRectangle(cornerRadius: 10)
Expand Down
3 changes: 2 additions & 1 deletion ...iOS/Cherrish-iOS/Presentation/Feature/ChallengeView/View/ChallengeSelectMissionView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ struct ChallengeSelectMissionView: View {
VStack {
VStack {
HStack {
VStack(alignment: .leading, spacing: 4.adjustedH) {
VStack(alignment: .leading) {
TypographyText("챌린지 기간 동안\n진행할 미션을 선택해주세요.",
style: .title1_sb_18,
color: .gray1000
Expand All @@ -28,6 +28,7 @@ struct ChallengeSelectMissionView: View {
color: .gray700
)
.frame(height: 20.adjustedH)
.padding(.top, 4.adjustedH)
}
Spacer()
}
Expand Down
15 changes: 13 additions & 2 deletions ...ources/Assets.xcassets/ChallengeImage/illustration_challenge_start.imageset/Contents.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,19 @@
{
"images" : [
{
"filename" : "illustration_challenge_start-1.svg",
"idiom" : "universal"
"filename" : "illustration_challenge_start.png",
"idiom" : "universal",
"scale" : "1x"
},
{
"filename" : "illustration_challenge_start@2x.png",
"idiom" : "universal",
"scale" : "2x"
},
{
"filename" : "illustration_challenge_start@3x.png",
"idiom" : "universal",
"scale" : "3x"
}
],
"info" : {
Expand Down
297 changes: 0 additions & 297 deletions ...eImage/illustration_challenge_start.imageset/illustration_challenge_start-1.svg
View file
Open in desktop

This file was deleted.

Binary file added ...ngeImage/illustration_challenge_start.imageset/illustration_challenge_start.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...Image/illustration_challenge_start.imageset/illustration_challenge_start@2x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added ...Image/illustration_challenge_start.imageset/illustration_challenge_start@3x.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.