fix: #163 2차QA 반영 #166
Open
fix: #163 2차QA 반영 #166
+16
−300
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sum130
requested review from
wotjs020708 and
y-eonee
and removed request for
a team
Open
1 task
📝 WalkthroughWalkthroughChallengeView 관련 UI 컴포넌트들에 레이아웃 조정을 적용하고, 챌린지 시작 일러스트 이미지를 SVG에서 PNG 형식(1x, 2x, 3x 스케일)으로 변경했습니다. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 분 Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@Cherrish-iOS/Cherrish-iOS/Presentation/Feature/ChallengeView/View/ChallengeProgressView.swift`:
- Line 128: The view uses a fixed height via the .frame(width: 326.adjustedW,
height: 320.adjustedH) modifier in ChallengeProgressView which can cause
text/image clipping with Dynamic Type or variable content; remove the hard-coded
height and make the layout flexible by replacing the fixed height with a minimum
height or flexible constraints (e.g., use .frame(width: 326.adjustedW,
minHeight: 320.adjustedH) or .frame(maxHeight: .infinity) and/or add
.fixedSize(horizontal: false, vertical: true) so the content can expand; update
the modifier applied to the view in ChallengeProgressView to use
minHeight/maxHeight or flexible sizing instead of the hard-coded height.
| } | ||
| .padding(.horizontal, 25.adjustedW) | ||
| } | ||
| .frame(width: 326.adjustedW, height: 320.adjustedH) |
There was a problem hiding this comment.
고정 높이로 인한 텍스트/이미지 클리핑 가능성
다이나믹 타입 확대나 문구 길이 변화 시 내부 콘텐츠가 잘릴 수 있어요. 최소 높이로 두고 확장되도록 여지를 두는 편이 안전합니다.
🛠️ 제안 수정안
- .frame(width: 326.adjustedW, height: 320.adjustedH)
+ .frame(width: 326.adjustedW, minHeight: 320.adjustedH, alignment: .top)📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| .frame(width: 326.adjustedW, height: 320.adjustedH) | |
| .frame(width: 326.adjustedW, minHeight: 320.adjustedH, alignment: .top) |
🤖 Prompt for AI Agents
In
`@Cherrish-iOS/Cherrish-iOS/Presentation/Feature/ChallengeView/View/ChallengeProgressView.swift`
at line 128, The view uses a fixed height via the .frame(width: 326.adjustedW,
height: 320.adjustedH) modifier in ChallengeProgressView which can cause
text/image clipping with Dynamic Type or variable content; remove the hard-coded
height and make the layout flexible by replacing the fixed height with a minimum
height or flexible constraints (e.g., use .frame(width: 326.adjustedW,
minHeight: 320.adjustedH) or .frame(maxHeight: .infinity) and/or add
.fixedSize(horizontal: false, vertical: true) so the content can expand; update
the modifier applied to the view in ChallengeProgressView to use
minHeight/maxHeight or flexible sizing instead of the hard-coded height.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔗 연결된 이슈
📄 작업 내용
👀 기타 더 이야기해볼 점
패딩 조정 지옥에 빠져...