Skip to content

[DOSBox-x Core] Fix for data+audio cds #4595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SergioMartin86 wants to merge 5 commits into
base: master
Choose a base branch
from
+9 −5
Open

[DOSBox-x Core] Fix for data+audio cds #4595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
63b2f07
Updating with fix for data+audio cds
SergioMartin86 Dec 29, 2025
a5427b4
Adding video buffer fix
Dec 29, 2025
53e7913
Fixing submodules
Dec 29, 2025
b307953
Fixing submodule
Dec 29, 2025
37e0836
Adding missing submodule and installed core
SergioMartin86 Dec 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified Assets/dll/dosbox.wbx.zst
View file
Open in desktop
Binary file not shown.
8 changes: 6 additions & 2 deletions src/BizHawk.Emulation.Cores/Computers/DOS/DOSBox.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,12 @@ public DOSBox(CoreLoadParameters<object, SyncSettings> lp)
_libDOSBox.PushCDData(curDiscIndex, CDDataStruct.End, CDDataStruct.Last);

// Passing track data to the core
for (var trackIdx = 0; trackIdx < CDDataStruct.Last; trackIdx++) _libDOSBox.PushTrackData(curDiscIndex, trackIdx, CDDataStruct.Tracks[trackIdx]);
}
for (var trackIdx = 0; trackIdx < CDDataStruct.Last; trackIdx++)
{
// Console.WriteLine($"[CD] Adding Track {trackIdx}. Start: {CDDataStruct.Tracks[trackIdx].Start}, End: {CDDataStruct.Tracks[trackIdx].End}, End: {CDDataStruct.Tracks[trackIdx].Offset}");
Copy link
Contributor

@vadosnaprimer vadosnaprimer Dec 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed I guess?

Copy link
Collaborator Author

@SergioMartin86 SergioMartin86 Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rather keep it there, in case I need to revisit I'll have some quick debug info available

_libDOSBox.PushTrackData(curDiscIndex, trackIdx, CDDataStruct.Tracks[trackIdx]);
}
}
////// CD Loading Logic End

// Getting base config file
Expand Down
4 changes: 2 additions & 2 deletions src/BizHawk.Emulation.Cores/Computers/DOS/LibDOSBox.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ public abstract class LibDOSBox : LibWaterboxCore

public const int VGA_MAX_WIDTH = 640;
public const int VGA_MAX_HEIGHT = 480;
public const int SVGA_MAX_WIDTH = 1024;
public const int SVGA_MAX_HEIGHT = 768;
public const int SVGA_MAX_WIDTH = 2560;
public const int SVGA_MAX_HEIGHT = 2048;

// Default FPS: 70.086592427616921
public const int DEFAULT_FRAMERATE_NUMERATOR_DOS = 3146888;
Expand Down
2 changes: 1 addition & 1 deletion waterbox/dosbox/dosbox-x
Open in desktop
Submodule dosbox-x updated 2 files
+25 −0 src/dos/cdrom.h
+88 −11 src/dos/cdrom_image.cpp