fix: validate dir before workspace search in memory discovery#65
fix: validate dir before workspace search in memory discovery#65TrueAlpha-spiral wants to merge 1 commit into
Conversation
Updated `memoryDiscovery.ts` to skip workspace search if `dir` is an empty string after trimming. This prevents unnecessary and potentially invalid filesystem lookups when an invalid currentWorkingDirectory is passed. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- PR #65: validate whitespace-only dir in memoryDiscovery.ts - PR #71: fix as unknown as Readable cast in shellExecutionService.test.ts - PR #93: parallelize @path file stat loop with Promise.all in atCommandProcessor.ts and add test" Agent-Logs-Url: https://github.com/Sovereign-Data-Foundation/gemini-cli/sessions/eeea9ea5-aa47-48b3-af4d-684ea7154a27 Co-authored-by: TrueAlpha-spiral <199723968+TrueAlpha-spiral@users.noreply.github.com>
Consolidates changes from PRs #65, #71, and #93. - PR #65: reject whitespace-only dir values in memoryDiscovery.ts - PR #71: use safer as unknown as Readable casts in shellExecutionService.test.ts - PR #93: parallelize @path file stat resolution with Promise.all in atCommandProcessor.ts - Preserve deterministic debug-message ordering after parallel @path resolution - Add typed AtPathResolutionResult outcomes for invalid, ignored, success, and skipped paths - Rename IgnoreReason to FileIgnoreReason - Rename ignoredByReason to ignoredPathsByReason This keeps the performance improvement while preserving deterministic observable behavior. Agent-Logs-Url: https://github.com/Sovereign-Data-Foundation/gemini-cli/sessions/eeea9ea5-aa47-48b3-af4d-684ea7154a27 Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: TrueAlpha-spiral <199723968+TrueAlpha-spiral@users.noreply.github.com>
1 participant
This PR updates
getGeminiMdFilePathsInternalForEachDirinmemoryDiscovery.tsto strictly validate the provideddirparameter before attempting upward and downward workspace scans.By checking
if (dir && dir.trim() !== ''), we ensure that strings consisting only of whitespace (which are technically truthy) are correctly ignored, preventing invalid file path resolutions.PR created automatically by Jules for task 2805786081596258419 started by @TrueAlpha-spiral