Apply non-draft open PRs: parallelize @path resolution, fix TS casts, harden dir validation#99
Merged
TrueAlpha-spiral merged 2 commits intoMay 11, 2026
Conversation
- PR #65: validate whitespace-only dir in memoryDiscovery.ts - PR #71: fix as unknown as Readable cast in shellExecutionService.test.ts - PR #93: parallelize @path file stat loop with Promise.all in atCommandProcessor.ts and add test" Agent-Logs-Url: https://github.com/Sovereign-Data-Foundation/gemini-cli/sessions/eeea9ea5-aa47-48b3-af4d-684ea7154a27 Co-authored-by: TrueAlpha-spiral <199723968+TrueAlpha-spiral@users.noreply.github.com>
… ignoredPathsByReason Agent-Logs-Url: https://github.com/Sovereign-Data-Foundation/gemini-cli/sessions/eeea9ea5-aa47-48b3-af4d-684ea7154a27 Co-authored-by: TrueAlpha-spiral <199723968+TrueAlpha-spiral@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
TrueAlpha-spiral
May 11, 2026 04:00
View session
Collaborator
Collaborator
|
I see strong financial incentives pushing AI systems to stay adaptable rather than fully auditable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Applies three non-draft open PRs into this branch. Core change:
@pathfile stat resolution now runs concurrently viaPromise.allinstead of serially, with debug message ordering preserved. Two smaller correctness fixes round it out.Dive Deeper
PR #93 — Parallelize
@pathstat resolution (atCommandProcessor.ts)for...of+awaitoveratPathCommandPartswithPromise.allover mapped async handlers.Promise.allsettles — preserving deterministic output.AtPathResolutionResult(invalid | ignored | success | skipped) to make result handling explicit and type-safe.IgnoreReasonrenamed →FileIgnoreReason;ignoredByReason→ignoredPathsByReasonfor clarity.PR #71 — Safer EventEmitter → Readable cast in
shellExecutionService.test.tsas Readable→as unknown as Readable: the double-cast is the correct TypeScript pattern when the types have no structural overlap. Removes the stale// FIXcomment.PR #65 — Reject whitespace-only
dirinmemoryDiscovery.tsif (dir)→if (dir && dir.trim() !== ''): truthy whitespace strings (e.g." ") would previously pass the guard and produce bogus resolved paths viapath.resolve.Reviewer Test Plan
@filereferences in a single query — confirm all resolve correctly and debug messages appear in input order.dirtogetGeminiMdFilePathsInternalForEachDir— confirm no path resolution is attempted.shellExecutionServicetests — confirm no TypeScript errors on the mock child process setup.Testing Matrix
Linked issues / bugs
Related to #93, #71, #65