a11y: drop inner <main> from ProfileView and EditProfileView#312
Closed
m5x5 wants to merge 1 commit into
Closed
Conversation
This was referenced May 11, 2026
m5x5
force-pushed
the
a11y/page-level-main-landmark
branch
from
97b2230 to
9dff30b
Compare
Both views wrapped their grid content in a <main>. With the shell's `#MainContent` also being a <main>, profile-pane pages had two nested <main> landmarks. The page-level <main> landmark now lives on the shell's `.app-view` in mashlib (see SolidOS/mashlib PR). Demote the inner element to a <div>, preserving id, class, and tabindex. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
m5x5
force-pushed
the
a11y/page-level-main-landmark
branch
from
9dff30b to
7b890c0
Compare
This was referenced May 12, 2026
Contributor
|
I made these changes manually bc I needed to change some things and it was orginally not pointing to my branch. sorry about that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<main>. With the shell's#MainContentalso being a<main>, profile-pane pages had two nested<main>landmarks.<main>landmark now lives on the shell's.app-view(see a11y: promote .app-view to the page-level <main> landmark mashlib#394). Demote the inner element to a<div>, preserving id, class, and tabindex.Addresses #310.
Coordinated PRs
.app-viewto the page-level<main>landmark (land first)<main>to<div>