Skip to content

a11y: render LDP container contents as <ul>, not a 2-column <table>#204

Open
m5x5 wants to merge 1 commit into
SolidOS:mainfrom
m5x5:a11y/list-of-resources
Open

a11y: render LDP container contents as <ul>, not a 2-column <table>#204
m5x5 wants to merge 1 commit into
SolidOS:mainfrom
m5x5:a11y/list-of-resources

Conversation

@m5x5
Copy link
Copy Markdown

@m5x5 m5x5 commented May 12, 2026

Summary

  • Every row in a folder listing has the same predicate (ldp:contains), so the markup is a list of resources, not a data table. Screen readers now announce "list, N items" instead of an opaque table.
  • mainTable is now <ul class="folder-listing"> with aria-label="Contents of <folder>". Each entry is a <li> wrapping the outliner's object cell (passed elementName='div' so it emits a <div>, not a stray <td> outside any table context).
  • Package branch (container holding an index.ttl): host element is <div class="folderPanePackageContents"> instead of <table> — rendering is delegated to GotoSubject and no row layout is needed.
  • CSS: drop .folderPaneMainTable / td / th / .folderPanePredicateCell rules; add .folder-listing / .folder-listing__item rules.

Addresses SolidOS/profile-pane#310.

Coordinated PRs

Every row in a folder listing has the same predicate (ldp:contains), so the
markup is a list of resources, not a data table. Screen readers now announce
"list, N items" instead of an opaque table.

- mainTable: <table class="folderPaneMainTable"> -> <ul class="folder-listing">
  with aria-label "Contents of <folder>". Each entry is a <li> wrapping the
  outliner's object cell (passed elementName='div' so it emits a <div>, not
  a stray <td> outside any table context).
- Package branch (container with index.ttl): host element is a <div
  class="folderPanePackageContents"> instead of <table> -- rendering is
  delegated to GotoSubject and no row layout is needed.
- CSS: drop .folderPaneMainTable / td / th / .folderPanePredicateCell rules;
  add .folder-listing / .folder-listing__item rules.
@m5x5 m5x5 marked this pull request as ready for review May 12, 2026 23:30
@m5x5
Copy link
Copy Markdown
Author

m5x5 commented May 12, 2026

I think we could remove the comments I added but besides that it looks good from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant