Skip to content

Update the specs to new signature and fix CI #2036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
charlespwd merged 4 commits into from
Jan 14, 2026
Merged

Update the specs to new signature and fix CI #2036

charlespwd merged 4 commits into from
Jan 14, 2026

Conversation

@charlespwd
Copy link
Contributor

@charlespwd charlespwd commented Jan 12, 2026 •
edited
Loading

  • Remove on pull_request CI trigger, it's redundant with push
  • Add the options to the CI check name to distinguish between them
  • Update the specs to the new signature

@charlespwd charlespwd changed the title Fix CI Fix rubocop Jan 12, 2026
@charlespwd @claude
Update liquid-spec adapters for new ctx-based API
aa817c4 
liquid-spec main changed the adapter API:
- compile block now receives (ctx, source, options) and should store
  the template in ctx[:template]
- render block now receives (ctx, assigns, options) and retrieves
  the template from ctx[:template]

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@charlespwd charlespwd mentioned this pull request Jan 13, 2026
Merged
@charlespwd charlespwd requested a review from ianks January 13, 2026 18:22
@charlespwd charlespwd changed the title Fix rubocop Update the specs to new signature and fix CI Jan 13, 2026
@charlespwd charlespwd requested a review from Maaarcocr January 13, 2026 18:40
@charlespwd charlespwd merged commit d897899 into main Jan 14, 2026
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Maaarcocr Maaarcocr Maaarcocr approved these changes

@ianks ianks Awaiting requested review from ianks

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@charlespwd @Maaarcocr