Fix lax specs & yaml error in error-handling.yml #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charlespwd
commented
Jan 13, 2026
Comment on lines
-203
to
-210
| errors: | ||
| parse_error: | ||
| - "unexpected" | ||
| - "filter" | ||
| expected: "HELLO" | ||
| hint: | | ||
| Double pipes (||) are not valid Liquid syntax. The lexer/parser should | ||
| detect malformed filter chains. While '|' separates filters, '||' is | ||
| invalid. Syntax errors should be detected during parsing. |
Contributor
Author
There was a problem hiding this comment.
Note that all this is going to be deleted once we get rid of lax.
Contributor
Author
|
With |
ianks
approved these changes
Jan 13, 2026
Maaarcocr
approved these changes
Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes CI for Shopify/liquid#2036
Had issues