Skip to content

Conversation

@kdaviduik
Copy link
Contributor

Reverts #3373.

After merging this ^ I cancelled the workflow run before it released. There is some sort of (seemingly new) bug in our changesets logic - this PR should have been for Hydrogen/Hydrogen React versions 2025.7.3, like the title of the PR (which gets auto-generated based on the changesets). Instead, inside the body of the PR it was going to release Hydrogen/Hydrogen React 2025.10.0.

Info on Hydrogen's versioning.

I suspect this bug was probably introduced as part of these changes (which also had several follow up fix PRs) to try to automate as much of this as possible. Since this was added we have only had "patch" changesets in Hydrogen/Hydrogen React, but this bug surfaced the first time we did a "minor" changeset.

As a follow up I will investigate this to fix the bug and get the 2025.7.3 release out.

@kdaviduik kdaviduik requested a review from a team as a code owner January 20, 2026 04:47
@shopify
Copy link
Contributor

shopify bot commented Jan 20, 2026

Oxygen deployed a preview of your revert-3373-changeset-release/main branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment January 20, 2026 4:47 AM
metaobjects ✅ Successful (Logs) Preview deployment Inspect deployment January 20, 2026 4:50 AM
sitemap ✅ Successful (Logs) Preview deployment Inspect deployment January 20, 2026 4:50 AM
custom-cart-method ✅ Successful (Logs) Preview deployment Inspect deployment January 20, 2026 4:50 AM
third-party-queries-caching ✅ Successful (Logs) Preview deployment Inspect deployment January 20, 2026 4:50 AM

Learn more about Hydrogen's GitHub integration.

Copy link
Contributor Author

kdaviduik commented Jan 20, 2026

Merge activity

  • Jan 20, 5:00 AM UTC: A user started a stack merge that includes this pull request via Graphite.
  • Jan 20, 5:01 AM UTC: @kdaviduik merged this pull request with Graphite.

@kdaviduik kdaviduik merged commit 7c077f5 into main Jan 20, 2026
17 of 18 checks passed
@kdaviduik kdaviduik deleted the revert-3373-changeset-release/main branch January 20, 2026 05:01
fredericoo pushed a commit that referenced this pull request Jan 20, 2026
Reverts #3373.

After merging this ^ I cancelled the workflow run before it released. There is some sort of (seemingly new) bug in our changesets logic - this PR should have been for Hydrogen/Hydrogen React versions 2025.7.3, like the title of the PR (which gets auto-generated based on the changesets). Instead, inside the body of the PR it was going to release Hydrogen/Hydrogen React 2025.10.0. 

[Info on Hydrogen's versioning](https://github.com/Shopify/hydrogen/blob/main/CLAUDE.md#version-strategy).

I suspect this bug was probably introduced as part of [these changes](#3111) (which also had several follow up fix PRs) to try to automate as much of this as possible. Since this was added we have only had "patch" changesets in Hydrogen/Hydrogen React, but this bug surfaced the first time we did a "minor" changeset. 

As a follow up I will investigate this to fix the bug and get the 2025.7.3 release out.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants