-
Notifications
You must be signed in to change notification settings - Fork 378
Fix test failing due to version bumps #3390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
We detected some changes in |
|
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
kdaviduik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad the versions are rendering correctly when h2 upgrade runs! these upgrade tests are too flaky, I definitely want us to improve that in the future.
I'm not sure why CI is failing on the recipes? Maybe you need to rebase with main?
Failing due to the false |
frandiox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we know why this broke? 👀
e326c10 to
d3979a1
Compare
We're seeing different values now and this needs to be updated to fix
main:This PR just gets
mainback in a good place but we might want to consider the flakiness of a lot of these tests.