-
Notifications
You must be signed in to change notification settings - Fork 223
only send auth headers for proxied theme requests #6770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Coverage report
Show new covered files 🐣
Show files with reduced coverage 🔻
Test suite run success3652 tests passing in 1428 suites. Report generated by 🧪jest coverage report action from 44a3911 |
|
/snapit |
graygilmore
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎩 👍🏻
.changeset/little-zebras-cut.md
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll merge it before the release, so I guess there's no need to add this, since it didn't affect any released version.
|
We detected some changes at Caution DO NOT create changesets for features which you do not wish to be included in the public changelog of the next CLI release. |
b50e7f4 to
44a3911
Compare
WHY are these changes introduced?
Our latest build, and main are having issues with
app devwhen using a theme app extension. We are getting intermittent auth token errors.WHAT is this pull request doing?
When proxying requests, we will only send theme related requests, not app related requests (including theme app extensions).
How to test your changes?
On main, run
app devwith a theme app extension.Go to localhost and try to fresh, you should see a token error
Pull down the branch
Build the branch
Run
app devagain and make sure you localhost is rendering even on multiple refreshes.Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist