fix: show stop button in chat input during follow-up questions#12272
Draft
roomote-v0[bot] wants to merge 1 commit intomainfrom
Draft
fix: show stop button in chat input during follow-up questions#12272roomote-v0[bot] wants to merge 1 commit intomainfrom
roomote-v0[bot] wants to merge 1 commit intomainfrom
Conversation
When the agent asks a follow-up question, the normal stop button in the chat input area was not visible because isStreaming is false during asks. This left users with no way to abort the task during follow-up questions. Added a dedicated stop button that appears in the chat text area when there is an active follow-up question (canStopTask prop). This button is separate from the morphing send/stop button, so users can both send a response AND stop the task. Fixes #12268
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #12268
Description
This PR attempts to address Issue #12268. Feedback and guidance are welcome.
Problem: When the agent asks a follow-up question, the normal stop button in the chat input area disappears because
isStreamingisfalseduring asks. The send/stop button morphs to a send button, and sinceprimaryButtonTextisundefinedfor followup asks, the action button bar is also hidden. This leaves users with no way to abort the task during follow-up questions.Solution: Added a dedicated stop button in
ChatTextAreathat appears when there is an active follow-up question. This is controlled by a newcanStopTaskprop passed fromChatView. The button:canStopTask=trueANDisStreaming=false(to avoid duplicate stop buttons)onStophandler (which sendscancelTaskto the extension)Key changes:
ChatTextArea.tsx: AddedcanStopTaskprop and a separate stop button that renders when the task can be stopped but is not streamingChatView.tsx: PassescanStopTask={!!task && !isStreaming && clineAsk === "followup"}to ChatTextAreaChatTextArea.spec.tsx: Added 4 new tests covering stop button visibility and click behaviorTest Procedure
canStopTask=trueand not streamingcanStopTask=falseonStopPre-Submission Checklist
Documentation Updates
Additional Notes
The fix is scoped specifically to
followupasks. Other ask types (tool, command, etc.) already have primary/secondary action buttons in the button bar that include reject/cancel options.Interactively review PR in Roo Code Cloud