fix: prevent write_to_file from creating files at truncated paths #10415
+37
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing streaming During streaming, the partial-json library may return truncated string values when chunk boundaries fall mid-value (e.g., 'sr' instead of 'src/core/prompts/sections/skills.ts'). This fix: 1. Waits for the path to stabilize (same value in consecutive partial blocks) before creating files 2. Updates diffViewProvider.relPath in execute() when isEditing is already true 3. Re-reads fresh block data for non-partial tool_use blocks Fixes ROO-311
dosubot
bot
added
size:M
Contributor
All issues resolved. The fix correctly adds
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
hannesrudolph
added
the
Issue/PR - Triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight simplification of #10414