fix: prevent write_to_file from creating files at truncated paths during streaming #10414
+310
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing streaming During streaming, the partial-json library may return truncated string values when chunk boundaries fall mid-value (e.g., 'sr' instead of 'src/core/prompts/sections/skills.ts'). This fix: 1. Waits for the path to stabilize (same value in consecutive partial blocks) before creating files 2. Updates diffViewProvider.relPath in execute() when isEditing is already true 3. Re-reads fresh block data for non-partial tool_use blocks Fixes ROO-311
dosubot
bot
added
size:L
Contributor
Review complete. No issues found. The fix for ROO-311 is well-implemented:
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
![roomote[bot]](https://avatars.githubusercontent.com/in/1546624?s=60&v=4){kind=small}
hannesrudolph
added
the
Issue/PR - Triage
mrubens
reviewed
Dec 31, 2025
Comment on lines
+103
to
+108
| if (block.type === "tool_use" && !block.partial) { | ||
| const freshBlock = cline.assistantMessageContent[cline.currentStreamingContentIndex] | ||
| if (freshBlock && freshBlock.type === "tool_use" && !freshBlock.partial) { | ||
| block = cloneDeep(freshBlock) | ||
| } | ||
| } |
mrubens
reviewed
Dec 31, 2025
| await task.ask("tool", partialMessage, block.partial).catch(() => {}) | ||
|
|
||
| if (newContent) { | ||
| // Only create the file and start streaming when the path has stabilized |
Collaborator
There was a problem hiding this comment.
If we're waiting to stream until the path stabilizes, do we still need the setRelPath?
mrubens
reviewed
Dec 31, 2025
Comment on lines
+22
to
+30
| * | ||
| * The issue was that during streaming, partial-json parsing could produce truncated | ||
| * values (e.g., path "sr" instead of "src/core/prompts/sections/skills.ts"). | ||
| * These truncated values would be cloned by presentAssistantMessage before the | ||
| * final tool_call_end event updated the array with correct data. | ||
| * | ||
| * The fix ensures that for non-partial tool_use blocks, we re-read from | ||
| * assistantMessageContent to get the final data, not stale partial data. | ||
| */ |
Collaborator
There was a problem hiding this comment.
I'm not sure this is 100% accurate - we just want to make sure the path is stable.
mrubens
reviewed
Dec 31, 2025
| // creating the file. This ensures we have the complete, final path value. | ||
| const pathHasStabilized = this.lastSeenPartialPath !== undefined && this.lastSeenPartialPath === relPath | ||
| this.lastSeenPartialPath = relPath | ||
|
|
Collaborator
There was a problem hiding this comment.
Maybe we should just return here if the path hasn't stabilized?
Collaborator
|
Closing in favor of #10415 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes ROO-311: write_to_file truncates filenames at special characters before file extension
During streaming, the partial-json library may return truncated string values when chunk boundaries fall mid-value (e.g., 'sr' instead of 'src/core/prompts/sections/skills.ts'). This caused files to be created at incorrect paths.
Changes
src/core/tools/WriteToFileTool.tslastSeenPartialPathtracking to detect path stabilization during streamingsetRelPath()call inexecute()to correct any stale path referenceresetPartialState()to clean up tracking state after tool completionsrc/integrations/editor/DiffViewProvider.tssetRelPath()method to update the relative path without re-opening the diff viewsrc/core/assistant-message/presentAssistantMessage.tsHow It Works
During streaming, the partial-json library may return truncated string values when chunk boundaries fall mid-value. The fix waits until the path stops changing between consecutive partial blocks before creating the file, ensuring we have the complete final path value.
Testing
presentAssistantMessage-stale-data.spec.ts(5 tests)writeToFileTool.spec.tsto account for path stabilization behaviorFixes ROO-311
Important
Fixes path truncation in
write_to_fileduring streaming by ensuring file creation only when paths stabilize, with updates inWriteToFileTool.ts,presentAssistantMessage.ts, andDiffViewProvider.ts.WriteToFileTool.tsby trackinglastSeenPartialPathand ensuring file creation only when paths stabilize.presentAssistantMessage.tsto re-read block data for non-partialtool_useblocks to ensure final data usage.setRelPath()inDiffViewProvider.tsto update paths without reopening views.presentAssistantMessage-stale-data.spec.tswith 5 new tests for path stabilization and data re-reading.writeToFileTool.spec.tsto test directory creation and content streaming after path stabilization.resetPartialState()inWriteToFileTool.tsto clear tracking state after execution or error.This description was created by
for 93f4fed. You can customize this summary. It will automatically update as commits are pushed.