Skip to content

Conversation

@meiravgri
Copy link
Collaborator

@meiravgri meiravgri commented Aug 31, 2025

Due to the change introduced in Homebrew/brew#20304, Homebrew now prevents installing formulae with the same name. This means that workflows attempting to install a formula already present will fail.

This PR fixes the error message failing macos WF by installing cmake only if it isn’t already present.

@meiravgri meiravgri changed the title try with macos14 Handle Homebrew conflicts: Install cmake only if not present Aug 31, 2025
@meiravgri meiravgri requested a review from alonre24 August 31, 2025 14:11
@meiravgri meiravgri enabled auto-merge August 31, 2025 14:34
@codecov
Copy link

codecov bot commented Aug 31, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.82%. Comparing base (8c4e80c) to head (1bd697f).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #754   +/-   ##
=======================================
  Coverage   96.82%   96.82%           
=======================================
  Files         122      122           
  Lines        7496     7496           
=======================================
  Hits         7258     7258           
  Misses        238      238           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@meiravgri meiravgri added this pull request to the merge queue Aug 31, 2025
Merged via the queue into main with commit d60ab7c Aug 31, 2025
30 checks passed
@meiravgri meiravgri deleted the meriavg_fix_install_mac branch August 31, 2025 18:33
github-actions bot pushed a commit that referenced this pull request Aug 31, 2025
* try with macos14

* uninstall cmake if exists

* uninstallcmake

* try with condiiton

(cherry picked from commit d60ab7c)
@github-actions
Copy link

Successfully created backport PR for 0.6:

github-actions bot pushed a commit that referenced this pull request Aug 31, 2025
* try with macos14

* uninstall cmake if exists

* uninstallcmake

* try with condiiton

(cherry picked from commit d60ab7c)
@github-actions
Copy link

Successfully created backport PR for 0.7:

@github-actions
Copy link

Successfully created backport PR for 0.8:

github-actions bot pushed a commit that referenced this pull request Aug 31, 2025
* try with macos14

* uninstall cmake if exists

* uninstallcmake

* try with condiiton

(cherry picked from commit d60ab7c)
github-actions bot pushed a commit that referenced this pull request Aug 31, 2025
* try with macos14

* uninstall cmake if exists

* uninstallcmake

* try with condiiton

(cherry picked from commit d60ab7c)
@github-actions
Copy link

Successfully created backport PR for 8.0:

@github-actions
Copy link

Successfully created backport PR for 8.2:

github-actions bot pushed a commit that referenced this pull request Aug 31, 2025
* try with macos14

* uninstall cmake if exists

* uninstallcmake

* try with condiiton

(cherry picked from commit d60ab7c)
github-merge-queue bot pushed a commit that referenced this pull request Sep 1, 2025
)

Handle Homebrew conflicts: Install cmake only if not present (#754)

* try with macos14

* uninstall cmake if exists

* uninstallcmake

* try with condiiton

(cherry picked from commit d60ab7c)

Co-authored-by: meiravgri <109056284+meiravgri@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Sep 1, 2025
)

Handle Homebrew conflicts: Install cmake only if not present (#754)

* try with macos14

* uninstall cmake if exists

* uninstallcmake

* try with condiiton

(cherry picked from commit d60ab7c)

Co-authored-by: meiravgri <109056284+meiravgri@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Sep 1, 2025
)

Handle Homebrew conflicts: Install cmake only if not present (#754)

* try with macos14

* uninstall cmake if exists

* uninstallcmake

* try with condiiton

(cherry picked from commit d60ab7c)

Co-authored-by: meiravgri <109056284+meiravgri@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants