[0.6] [MOD-7297] Replace Variable Length Array on stack with heap allocation #762
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meiravgri
changed the title
alonre24
previously approved these changes
Sep 2, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 0.6 #762 +/- ##
==========================================
+ Coverage 95.03% 95.04% +0.01%
==========================================
Files 60 60
Lines 3425 3432 +7
==========================================
+ Hits 3255 3262 +7
Misses 170 170 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
alonre24
previously approved these changes
Sep 2, 2025
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 2, 2025
…ocation (#762) * avoid vla * install cmake only if doesnt exist
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alonre24
reviewed
Sep 3, 2025
| ARCH_OPT_NEON, | ||
| ARCH_OPT_SVE, | ||
| ARCH_OPT_SVE2, | ||
| ARCH_OPT_SIZE, |
Collaborator
There was a problem hiding this comment.
Suggested change
| ARCH_OPT_SIZE, | |
| ARCH_OPT_EDGE, |
or something like that, so it will be clearer that we are using the optimization in the test
alonre24
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
Manual backport of #505 to 0.6.
Changes from original PR:
Additional fixes:
Backport #754 to allow building on macOS
Install cmake only if it not present.
Bump cpu_features version from v0.9.0 to v0.10.1.
The previous version had a bug that caused
getArchitectureOptimization()to returnARCH_OPT_NONEinstead of detectingNEON/SVEoptimizations on macOS ARM64, particularly affecting macOS 15 runners. This was fixed in cpu_features v0.10.0 with PR #321 "fix: macos aarch64 detection" (see release notes under Bug Fixes).Fixed out of bound write in test_spaces.cpp
build_arm_funcs_array_fp32initializesfuncsarray size withARCH_OPT_SVE2(value 3), but code was accessingfuncs[ARCH_OPT_SVE2](index 3), which is out of bounds for a 3-element array.ARCH_OPT_SIZE = 4as the last enum value ofArch_Optimizationto represent the total count, then used it for array sizing.