Skip to content

fix: Do not use custom input labels for connection positions and move start #9932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mikeharv merged 2 commits into from
May 26, 2026
+2 −2
Merged

fix: Do not use custom input labels for connection positions and move start #9932

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
40b0cd8
fix: Do not use custom input labels on move start announcements
mikeharv May 26, 2026
f409024
fix: do not use custom input labels on input labels subset
mikeharv May 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/blockly/core/block_aria_composer.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ export function getInputLabelsSubset(block: BlockSvg, input: Input): string[] {
.filter((input) => input.isVisible())
.map(
(input) =>
input.getLabel(Verbosity.TERSE) ||
input.getLabel(Verbosity.TERSE, false) ||
Msg['INPUT_LABEL_INDEX'].replace(
'%1',
(input.getIndex() + 1).toString(),
Expand Down
2 changes: 1 addition & 1 deletion packages/blockly/core/block_svg.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2051,7 +2051,7 @@ export class BlockSvg
block = block.getNextBlock();
}
if (count <= 1) {
return computeAriaLabel(this, aria.Verbosity.TERSE);
return computeAriaLabel(this, aria.Verbosity.TERSE, false);
}

const labelTemplate = Msg['BLOCK_LABEL_STACK_BLOCKS'];
Expand Down
Loading