Skip to content

fix: Do not use custom input labels for connection positions and move start#9932

Merged
mikeharv merged 2 commits into
RaspberryPiFoundation:v13from
mikeharv:no-custom-inputs-on-start-move
May 26, 2026
Merged

fix: Do not use custom input labels for connection positions and move start#9932
mikeharv merged 2 commits into
RaspberryPiFoundation:v13from
mikeharv:no-custom-inputs-on-start-move

Conversation

@mikeharv
Copy link
Copy Markdown
Contributor

@mikeharv mikeharv commented May 26, 2026

The basics

The details

Resolves

Fixes #9922

Proposed Changes

Stop using custom input labels when computing block ARIA labels for the start of a move announcement.

Before:

image

After:

image

Stop using custom input labels when using a subset of input labels, for example, when focusing a statement input on a container block.

Before:

image

After:

image

Reason for Changes

Fixes two bugs where custom input labels are used in place of more useful computed labels from fields.

Additional Information

I think it would be worth considering making useCustomLabels default to false.

@mikeharv mikeharv requested a review from a team as a code owner May 26, 2026 16:32
@mikeharv mikeharv requested a review from maribethb May 26, 2026 16:32
@github-actions github-actions Bot added the PR: fix Fixes a bug label May 26, 2026
@github-actions github-actions Bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 26, 2026
@github-actions github-actions Bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 26, 2026
@mikeharv mikeharv requested a review from maribethb May 26, 2026 16:49
@mikeharv mikeharv changed the title fix: Do not use custom input labels on move start announcements fix: Do not use custom input labels for connection positions and move start May 26, 2026
@github-actions github-actions Bot added PR: fix Fixes a bug and removed PR: fix Fixes a bug labels May 26, 2026
@mikeharv mikeharv merged commit e2cf797 into RaspberryPiFoundation:v13 May 26, 2026
9 checks passed
@mikeharv mikeharv deleted the no-custom-inputs-on-start-move branch May 26, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR: fix Fixes a bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants