Skip to content

Conversation

@kabrahamAMD
Copy link
Contributor

@kabrahamAMD kabrahamAMD commented Jan 7, 2026

Addressed review comments from #3459 , and updated README.

During #3459 , there were two comments, which are addressed here:

  • moved all constraints not used externally to detail namespace
  • added check for ElementwiseOpWellDefinedIfProvided to ConvSignatureDescriptor

Also, while reviewing the latter I realized the README needs updating, which was also done

@kabrahamAMD kabrahamAMD changed the title [Draft] [CK_Builder] Updated README, adressed review comments from PR3459 [CK_Builder] Updated README, adressed review comments from PR3459 Jan 8, 2026
@kabrahamAMD kabrahamAMD merged commit 20f66c1 into develop Jan 12, 2026
21 checks passed
@kabrahamAMD kabrahamAMD deleted the kabraham/ck_builder_concepts_review_comments branch January 12, 2026 08:47
@afagaj afagaj changed the title [CK_Builder] Updated README, adressed review comments from PR3459 [CK_Builder] Updated README, addressed review comments from PR3459 Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants